feat(DataTable): allow additional contents to expand cells

[asudoh]

This change adds children prop support to <TableExpandHeader>. This provides applications with more control so application can better describe the expand cell.

Fixes #5028.

Changelog

New

• children prop support to <TableExpandHeader>.

Testing / Reviewing

Testing should make sure our data table is not broken.

[netlify]

Deploy preview for the-carbon-components ready!

Built with commit f8a2093

https://deploy-preview-5060--the-carbon-components.netlify.com

[netlify]

Deploy preview for carbon-components-react ready!

Built with commit f8a2093

https://deploy-preview-5060--carbon-components-react.netlify.com

[netlify]

Deploy preview for carbon-elements ready!

Built with commit f8a2093

https://deploy-preview-5060--carbon-elements.netlify.com

[tw15egan]

LGTM

[joshblack]

Do we need to add a prop type for children? If so, should it be PropTypes.string or PropTypes.node? 🤔

[emyarod]

looks good to me, I'm leaning towards setting the children prop type to string based on current usage examples

[tw15egan]

If they are going to need to hide whatever text they place there for a11y purposes, they're going to have to pass in a node with a visually-hidden class, so I'm leaning towards node

[joshblack]

If we're adding this for a11y should we wrap children in bx--assistive-text (or visually hidden) and set the prop type as string?

[tw15egan]

@joshblack depends on if this is the only use case we have for adding this text. If yes, then yeah we might as well hook it all up for them. Not sure if users will ever need this content to be visible

[joshblack]

Totally fair!

Real quick, when looking at the original issue are they looking for the aria-label prop to label the button in the th?

[asudoh]

Real quick, when looking at the original issue are they looking for the aria-label prop to label the button in the th?

Quick look at the original issue I couldn't find any mention of aria-label, but let us know if there was what led to such thoughts.

[joshblack]

I think it's just me misunderstanding things, thanks for checking in! It does seem like we'd want to go down the route of giving the option to supply text to be announced by a screen reader but not necessarily have it visually rendered, would that make sense with how everyone is interpreting this with respect to the data table design?

[asudoh]

It does seem like we'd want to go down the route of giving the option to supply text to be announced by a screen reader but not necessarily have it visually rendered, would that make sense with how everyone is interpreting this with respect to the data table design?

Looking at #5028, the hard requirement seems the ability for application to add text to table expand cells. It makes sense for the sake of flexibility. The specifics above may have some room for discussion, so what #5028 requests for sounds a good stop-gap.