Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(type): update link to type styles in README #5058

Merged
merged 9 commits into from
Jan 17, 2020
Merged

docs(type): update link to type styles in README #5058

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ab6ebb7
docs(type): update link to type styles in README
jendowns Jan 15, 2020
5607773
docs(type): update README text for context
jendowns Jan 15, 2020
11ee224
Merge branch 'master' into patch-9
jendowns Jan 15, 2020
c6e6ca5
chore: format type package README doc
jendowns Jan 16, 2020
570e54a
Merge branch 'master' into patch-9
jendowns Jan 16, 2020
8bb4891
Merge branch 'master' into patch-9
jendowns Jan 16, 2020
168faa9
Merge branch 'master' into patch-9
jendowns Jan 17, 2020
600a231
Merge branch 'master' into patch-9
emyarod Jan 17, 2020
19dc544
Merge branch 'master' into patch-9
joshblack Jan 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/type/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ what we call type styles. These tokens have a variety of properties for styling
how text is rendered on a page.

You can find a full reference of the type styles that are available
[here](https://next.carbondesignsystem.com/guidelines/typography/productive) .
[Carbon Design System website](https://www.carbondesignsystem.com/guidelines/typography/productive) .
Copy link
Contributor

@joshblack joshblack Jan 15, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update the sentence? Could you explain more about the accessibility shortcoming?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I mean to update the sentence completely, to avoid having link text that just says "here"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry just noticed your edit --

Here's two quick resources I found to explain this:

In addition to the reasons about context provided in those links, if you are using a screenreader + tabbing between focusable elements you may just hear "Link Here" or "Link Click here" which isn't helpful.


You can include a token in your Sass file by writing:

Expand Down