Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(pictograms-react): update example storybook name #5025

Merged
merged 2 commits into from
Jan 13, 2020
Merged

chore(pictograms-react): update example storybook name #5025

merged 2 commits into from
Jan 13, 2020

Conversation

jendowns
Copy link
Contributor

When you run yarn test you get a jest-haste-map naming collision --

jest-haste-map: Haste module naming collision: carbon-icons-react-storybook
  The following files share their name; please adjust your hasteImpl:
    * <rootDir>/packages/pictograms-react/examples/storybook/package.json
    * <rootDir>/packages/icons-react/examples/storybook/package.json

So this PR changes the duplicate name in @carbon/pictograms-react's storybook example to avoid the collision.

Changelog

Changed

  • update example storybook name in `@carbon/pictograms-react

@jendowns jendowns requested a review from a team as a code owner January 13, 2020 22:39
@ghost ghost requested review from dakahn and emyarod January 13, 2020 22:39
asudoh
asudoh approved these changes Jan 13, 2020
View reviewed changes
Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 - Thanks @jendowns!

@netlify
Copy link

netlify bot commented Jan 13, 2020 •
edited
Loading

Deploy preview for the-carbon-components ready!

Built with commit b1c0937

https://deploy-preview-5025--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Jan 13, 2020 •
edited
Loading

Deploy preview for carbon-components-react ready!

Built with commit b1c0937

https://deploy-preview-5025--carbon-components-react.netlify.com

@netlify
Copy link

netlify bot commented Jan 13, 2020 •
edited
Loading

Deploy preview for carbon-elements ready!

Built with commit b1c0937

https://deploy-preview-5025--carbon-elements.netlify.com

@asudoh asudoh merged commit 14c30eb into carbon-design-system:master Jan 13, 2020
joshblack pushed a commit to joshblack/carbon that referenced this pull request Jan 23, 2020
@jendowns @joshblack
chore(pictograms-react): update example storybook name (carbon-design…
bc00519 
…-system#5025)
@joshblack joshblack mentioned this pull request Jan 23, 2020
Closed
@joshblack joshblack mentioned this pull request Jan 31, 2020
Closed
@joshblack joshblack mentioned this pull request Feb 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asudoh asudoh asudoh approved these changes

@joshblack joshblack joshblack approved these changes

@dakahn dakahn Awaiting requested review from dakahn

@emyarod emyarod Awaiting requested review from emyarod

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jendowns @asudoh @joshblack