chore(release): v10.9.2

.github/ISSUE_TEMPLATE/accessibility-issue.md

@@ -1,5 +1,5 @@
 ---
-name: Accessibility Issue ♿
+name: Accessibility Issue
 about: Report an accessibility or usability issue
 title: ''
 labels: 'type: a11y ♿'

.github/ISSUE_TEMPLATE/bug-report.md

@@ -1,8 +1,8 @@
 ---
-name: "Bug Report \U0001F41B"
+name: 'Bug Report 🐛'
 about: Something isn't working as expected? Here is the right place to report.
 title: ''
-labels: "type: bug \U0001F41B"
+labels: 'type: bug 🐛'
 assignees: ''
 ---
 

.github/ISSUE_TEMPLATE/config.yml

@@ -0,0 +1 @@
+blank_issues_enabled: true

.github/ISSUE_TEMPLATE/feature-request-or-enhancement.md

@@ -1,8 +1,8 @@
 ---
-name: "Feature request or enhancement \U0001F4A1"
+name: 'Feature request or enhancement 💡'
 about: Suggest an idea for this project
 title: ''
-labels: "type: enhancement \U0001F4A1"
+labels: 'type: enhancement 💡'
 assignees: ''
 ---
 
@@ -15,18 +15,22 @@ If you are reporting a bug or problem, please use the bug template instead.
 
 Please describe your request in one or two sentences.
 
-Clarify if you are asking for both design and development, or just design, or
-just development.
+Clarify if you are asking for design, development, or both design and
+development.
 
 ### Justification
 
 Provide the business reasons for this request.
 
 ### Desired UX and success metrics
 
+<!--alex disable failure-->
+
 Describe the full user experience for this feature. Also define the metrics by
 which we can measure success/failure for the user.
 
+<!--alex enable failure-->
+
 ### "Must have" functionality
 
 Highlight any "must have" needs and functionality for the request.
@@ -36,9 +40,13 @@ you to define functionality based on the desired UX.
 
 ### Specific timeline issues / requests
 
+<!--alex disable period-->
+
 Do you want this work within a specific time period? Is it related to an
 upcoming release?
 
+<!--alex enable period-->
+
 _NB: The Carbon team will try to work with your timeline, but it's not
 guaranteed. The earlier you make a request in advance of a desired delivery
 date, the better!_

.github/ISSUE_TEMPLATE/question.md

@@ -1,8 +1,8 @@
 ---
 name: Question ❓
-about: Usage question or discussion about Carbon Components.
+about: Usage question or discussion about Carbon components
 title: ''
-labels: 'type: question :question:'
+labels: 'type: question ❓'
 assignees: ''
 ---
 

.github/stale.yml

@@ -6,11 +6,11 @@ daysUntilClose: 3
 exemptLabels:
   - 'type: a11y ♿'
   - 'type: bug 🐛'
-  - 'Severity 1 🚨'
-  - 'priority: high'
-  - 'v11'
+  - 'severity: 1 🚨'
+  - 'impact: 1'
+  - 'version: 11'
 # Label to use when marking an issue as stale
-staleLabel: inactive
+staleLabel: 'status: inactive'
 # Comment to post when marking an issue as stale. Set to `false` to disable
 markComment: >
   We've marked this issue as stale because there hasn't been any activity for a couple of weeks.

.yarnrc

@@ -2,7 +2,7 @@
 # yarn lockfile v1
 
 
-lastUpdateCheck 1570572520160
+lastUpdateCheck 1576080308559
 yarn-offline-mirror "./.yarn/offline-mirror"
 yarn-offline-mirror-pruning true
-yarn-path ".yarn/releases/yarn-1.19.1.js"
+yarn-path ".yarn/releases/yarn-1.21.1.js"

CODEOWNERS

@@ -1,9 +1,9 @@
 # Default global
 * @carbon-design-system/developers-system
 
-# Core icons
-/packages/icons/src/svg/16/ @laurenmrice @carbon-design-system/developers-system
-/packages/icons/src/svg/glyph/ @laurenmrice @carbon-design-system/developers-system
+# Core icons and pictograms
+/packages/icons/svg/ @laurenmrice @conradennis @carbon-design-system/developers-system
+/packages/pictograms/svg/ @laurenmrice @conradennis @carbon-design-system/developers-system
 
 # Angular icons
 /packages/icons-angular/ @cal-smith @carbon-design-system/developers-system

README.md

@@ -60,7 +60,7 @@ we support!
 ## :books: Documentation
 
 - See our documentation site
-  [here](http://carbondesignsystem.com/getting-started/developers) for full
+  [here](https://www.carbondesignsystem.com/get-started/develop/react) for full
   how-to docs and guidelines
 - [Contributing](/.github/CONTRIBUTING.md): Guidelines for making contributions
   to this repo.

docs/style.md

@@ -60,6 +60,9 @@ row before the </tbody></table> line.
 ## Table of Contents
 
 - [Introduction](#introduction)
+- [JavaScript](#javascript)
+  - [Style](#style)
+    - [Be explicit](#be-explicit)
 - [React](#react)
   - [Guidelines](#guidelines)
     - [Writing a component](#writing-a-component)
@@ -90,6 +93,69 @@ code:
 _Inspired by
 [Minimal API Surface Area](https://www.youtube.com/watch?v=4anAwXYqLG8)_
 
+## JavaScript
+
+### Style
+
+#### Be explicit
+
+<table>
+<thead><tr><th>Unpreferred</th><th>Preferred</th></tr></thead>
+<tbody>
+<tr><td>
+
+```jsx
+const add = (a, b) => a + b;
+```
+
+</td><td>
+
+```jsx
+const add = (a, b) => {
+  return a + b;
+};
+```
+
+</td></tr>
+</tbody></table>
+
+Certain features in JavaScript have implicit behavior. One of these that we see
+most often is the implicit return behavior of arrow function expressions, for
+example:
+
+```js
+const add = (a, b) => a + b;
+```
+
+We've found that, while this style is terse and compact, it can be at odds with
+the fact that code is revisited often and that developers need to peak inside
+sometimes to see what is going on. For example, if we needed to debug a specific
+value in the function above then we would go through the following steps:
+
+```js
+// Step 1. The code as originally authored
+const add = (a, b) => a + b;
+
+// Step 2. Update the code to no longer use the implicit return
+const add = (a, b) => {
+  return a + b;
+};
+
+// Step 3. Add any debugging code or ways to introspect its values
+const add = (a, b) => {
+  console.log(a);
+  return a + b;
+};
+
+// Step 4. Undo these changes and bring back to original format
+const add = (a, b) => a + b;
+```
+
+If instead we had written this code without the implicit return then we would
+have saved three out of the four steps above. As a result, we tend to favor
+being explicit in how JavaScript is written instead of relying on implicit
+behavior.
+
 ## React
 
 ### Guidelines
@@ -141,3 +207,65 @@ MyComponent.propTypes = {
 _Note: not every component will mirror the structure above. Some will need to
 incorporate `useEffect`, some will not. You can think of the outline above as
 slots that you can fill if you need this functionality in a component._
+
+### Style
+
+#### Naming event handlers
+
+<table>
+<thead><tr><th>Unpreferred</th><th>Preferred</th></tr></thead>
+<tbody>
+<tr><td>
+
+```jsx
+function MyComponent() {
+  function click() {
+    // ...
+  }
+  return <button onClick={click} />;
+}
+```
+
+</td><td>
+
+```jsx
+function MyComponent() {
+  function onClick() {
+    // ...
+  }
+  return <button onClick={onClick} />;
+}
+```
+
+</td></tr>
+<tr><td>
+
+```jsx
+function MyComponent({ onClick }) {
+  function handleClick(event) {
+    // ...
+    onClick(event);
+  }
+  return <button onClick={handleClick} />;
+}
+```
+
+</td><td>
+
+```jsx
+function MyComponent({ onClick }) {
+  function handleOnClick(event) {
+    // ...
+    onClick(event);
+  }
+  return <button onClick={handleOnClick} />;
+}
+```
+
+</td></tr>
+</tbody></table>
+
+When writing event handlers, we prefer using the exact name, `onClick` to a
+shorthand. If that name is already being used in a given scope, which often
+happens if the component supports a prop `onClick`, then we prefer to specify
+the function as `handleOnClick`.

package.json

@@ -42,7 +42,7 @@
     "@babel/preset-env": "^7.4.4",
     "@babel/preset-react": "^7.0.0",
     "@babel/runtime": "^7.4.4",
-    "@carbon/cli": "10.7.0-rc.0",
+    "@carbon/cli": "10.7.1-rc.0",
     "@commitlint/cli": "^7.5.2",
     "@commitlint/config-conventional": "^7.5.0",
     "@ibma/aat": "https://able.ibm.com/tools/dist/ibma-aat-2.0.3-alpha.tgz",
@@ -65,7 +65,7 @@
     "jest-junit": "^6.4.0",
     "lerna": "^3.13.4",
     "lint-staged": "^8.1.5",
-    "prettier": "^1.17.0",
+    "prettier": "^1.19.1",
     "react": "^16.8.6",
     "react-dom": "^16.8.6",
     "rimraf": "^2.6.3",

packages/bundler/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@carbon/bundler",
   "description": "Bundler used for libraries in the Carbon Design System",
-  "version": "10.5.0-rc.0",
+  "version": "10.5.1-rc.0",
   "license": "Apache-2.0",
   "bin": {
     "bundler": "./bin/bundler.js"

packages/bundler/src/bundlers/index.js

@@ -10,6 +10,9 @@
 const javascript = require('./javascript');
 const scss = require('./scss');
 
-const bundlers = new Map([['.js', javascript], ['.scss', scss]]);
+const bundlers = new Map([
+  ['.js', javascript],
+  ['.scss', scss],
+]);
 
 module.exports = bundlers;