fix(InlineLoading): change error icon to filled #5018
Conversation
ghost
requested review from
|
Deploy preview for the-carbon-components ready! Built with commit aaed1b6 https://deploy-preview-5018--the-carbon-components.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit aaed1b6 |
|
Deploy preview for carbon-components-react ready! Built with commit aaed1b6 https://deploy-preview-5018--carbon-components-react.netlify.com |
There was a problem hiding this comment.
it didn't look like there was an issue attached to the original PR so I'm not sure if there was any design feedback about the error icon change. do you have more context about that change? cc @aagonzales since she was taking a look at #4810
asudoh
requested review from
a team and
designertyler
and removed request for
a team
|
@emyarod I believe the feedback was from: #4810 (review) |
There was a problem hiding this comment.
looks good to me, reviewed with @designertyler. it looks like the old icon was Error20 but resized to 16x16
…#5018) Co-authored-by: TJ Egan <[email protected]> Co-authored-by: Josh Black <[email protected]> Co-authored-by: emyarod <[email protected]>
Related to #4810
This PR only affects the error icon change, not the added warning state.