Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(text-area): change disabled light textarea background colors #4983

Merged

Conversation

tw15egan
Copy link
Member

@tw15egan tw15egan commented Jan 8, 2020

Closes #4964

We don't want the field background changing when a textarea is disabled. I was also investigating why placeholder colors are not correct, but I wasn't able to modify any of them unless I used an !important...

@tw15egan tw15egan requested a review from a team as a code owner January 8, 2020 23:02
Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 - Thanks @tw15egan!

@asudoh asudoh requested review from a team and aagonzales and removed request for a team January 8, 2020 23:05
@netlify
Copy link

netlify bot commented Jan 8, 2020

Deploy preview for the-carbon-components ready!

Built with commit 02b4a88

https://deploy-preview-4983--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Jan 8, 2020

Deploy preview for carbon-components-react ready!

Built with commit 02b4a88

https://deploy-preview-4983--carbon-components-react.netlify.com

@netlify
Copy link

netlify bot commented Jan 8, 2020

Deploy preview for carbon-elements failed.

Built with commit 02b4a88

https://app.netlify.com/sites/carbon-elements/deploys/5e165f9db3e5f1000a45dc93

@netlify
Copy link

netlify bot commented Jan 8, 2020

Deploy preview for the-carbon-components ready!

Built with commit e4517ed

https://deploy-preview-4983--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Jan 8, 2020

Deploy preview for carbon-elements failed.

Built with commit 2682088

https://app.netlify.com/sites/carbon-elements/deploys/5e1753c6ebb2f60008c0c57d

@netlify
Copy link

netlify bot commented Jan 8, 2020

Deploy preview for carbon-components-react ready!

Built with commit b8adc31

https://deploy-preview-4983--carbon-components-react.netlify.com

@netlify
Copy link

netlify bot commented Jan 8, 2020

Deploy preview for the-carbon-components ready!

Built with commit b8adc31

https://deploy-preview-4983--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Jan 9, 2020

Deploy preview for the-carbon-components ready!

Built with commit 2682088

https://deploy-preview-4983--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Jan 9, 2020

Deploy preview for carbon-components-react failed.

Built with commit 2682088

https://app.netlify.com/sites/carbon-components-react/deploys/5e1753c64b02060008198476

Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tw15egan tw15egan merged commit 2474a06 into carbon-design-system:master Jan 9, 2020
@tw15egan tw15egan deleted the text-area-disabled-fix branch January 9, 2020 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[text input]: Disabled text area using the wrong color token
4 participants