Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace heading-01 with productive-heading-01 #4399

Merged

Conversation

emyarod
Copy link
Member

@emyarod emyarod commented Oct 21, 2019

Closes #4391

This PR replaces references to the deprecated heading-01 type token with productive-heading-01

Changelog

Changed

  • vanilla demo page
  • data table
  • date picker (and flatpickr base)
  • file uploader
  • notification
  • structured list
  • tabs
  • tooltip
  • UI shell side nav and switcher

Testing / Reviewing

Ensure the affected components are visually correct

@emyarod emyarod requested a review from a team as a code owner October 21, 2019 15:04
@ghost ghost requested a review from dakahn October 21, 2019 15:04
@netlify
Copy link

netlify bot commented Oct 21, 2019

Deploy preview for the-carbon-components ready!

Built with commit dc24200

https://deploy-preview-4399--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Oct 21, 2019

Deploy preview for carbon-components-react ready!

Built with commit dc24200

https://deploy-preview-4399--carbon-components-react.netlify.com

@netlify
Copy link

netlify bot commented Oct 21, 2019

Deploy preview for carbon-elements ready!

Built with commit dc24200

https://deploy-preview-4399--carbon-elements.netlify.com

Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@joshblack joshblack merged commit 817dd55 into carbon-design-system:master Oct 21, 2019
@emyarod emyarod deleted the 4391-update-heading-01-tokens branch October 22, 2019 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update heading-01 to productive-heading-01
4 participants