fix(storybook): use productive-heading-03 and 04 instead of expressive #4387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
|
Deploy preview for the-carbon-components ready! Built with commit 3120c50 https://deploy-preview-4387--the-carbon-components.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit 3120c50 |
|
Deploy preview for carbon-components-react failed. Built with commit 3120c50 https://app.netlify.com/sites/carbon-components-react/deploys/5da9c2ba8a9305000895f4ef |
joshblack
approved these changes
Oct 18, 2019
laurenmrice
approved these changes
Oct 18, 2019
|
Quick note, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4386 according to feedback in #4330
This PR removes the expressive heading tokens and adds
productive-heading-03andproductive-heading-04to the Carbon Type panel in the React storybookChangelog
New
productive-heading-03andproductive-heading-04type token knobsRemoved
expressive-heading-01andexpressive-heading-2type token knobsTesting / Reviewing
ensure the Carbon Type storybook panel functions as expected