docs(storybook): add type token switcher #4359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
|
Deploy preview for the-carbon-components ready! Built with commit e8aa2ef https://deploy-preview-4359--the-carbon-components.netlify.com |
|
Deploy preview for carbon-components-react ready! Built with commit e8aa2ef https://deploy-preview-4359--carbon-components-react.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit e8aa2ef |
abbeyhrt
approved these changes
Oct 17, 2019
joshblack
approved these changes
Oct 17, 2019
abbeyhrt
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: visual review 🔍
labels
|
@abbeyhrt really the only fast way is to inspect the styles, sadly 😞 There is the SassDoc too that might help: https://github.com/carbon-design-system/carbon/blob/master/packages/components/docs/sass.md#accordion-mixin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4329
This PR creates a storybook addon for modifying Carbon type token font size and line height. When a type token font size/line height pairing is selected for a particular type token, the corresponding custom properties for those rules is modified
Changelog
New
Changed
Testing / Reviewing
Change type token font size/line height pairings in the new Carbon Type storybook panel
Ensure the type tokens change as expected and are reflected in the DOM and storybook