Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(pictograms): update README.md #4317

Merged
merged 4 commits into from
Oct 14, 2019
Merged

docs(pictograms): update README.md #4317

merged 4 commits into from
Oct 14, 2019

Conversation

joshblack
Copy link
Contributor

Closes #4314

Changelog

New

Changed

  • Update README for @carbon/pictograms-react to use Airplane example

Removed

@joshblack joshblack requested a review from a team as a code owner October 14, 2019 13:56
@ghost ghost requested review from aledavila and asudoh October 14, 2019 13:56
@joshblack joshblack changed the title Update README.md docs(pictograms): update README.md Oct 14, 2019
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

regarding the 2nd point of the issue

- Note: if you would like to find the import path for an icon, you can reference our [Icon Library](https://www.carbondesignsystem.com/guidelines/icons/library/)
+ Note: if you would like to find the import path for a pictogram, you can reference our [Pictogram Library](https://www.carbondesignsystem.com/guidelines/pictograms/library)

@netlify
Copy link

netlify bot commented Oct 14, 2019

Deploy preview for the-carbon-components ready!

Built with commit 4392894

https://deploy-preview-4317--the-carbon-components.netlify.com

@joshblack
Copy link
Contributor Author

Thanks @emyarod !

@netlify
Copy link

netlify bot commented Oct 14, 2019

Deploy preview for carbon-elements failed.

Built with commit af1e361

https://app.netlify.com/sites/carbon-elements/deploys/5da47e96005e4a00088798c2

@netlify
Copy link

netlify bot commented Oct 14, 2019

Deploy preview for carbon-components-react ready!

Built with commit af1e361

https://deploy-preview-4317--carbon-components-react.netlify.com

@netlify
Copy link

netlify bot commented Oct 14, 2019

Deploy preview for carbon-elements ready!

Built with commit 4392894

https://deploy-preview-4317--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Oct 14, 2019

Deploy preview for carbon-components-react ready!

Built with commit 4392894

https://deploy-preview-4317--carbon-components-react.netlify.com

@joshblack joshblack merged commit 4959349 into master Oct 14, 2019
@joshblack joshblack deleted the joshblack-patch-1 branch October 14, 2019 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: README in @carbon/pictograms-react has incorrect usage information
3 participants