fix(pagination): update flex:1 and update top offset to fix IE11 #4315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Deploy preview for the-carbon-components ready! Built with commit 01a823b https://deploy-preview-4315--the-carbon-components.netlify.com |
|
Deploy preview for carbon-components-react failed. Built with commit 01a823b https://app.netlify.com/sites/carbon-components-react/deploys/5da737ffcc8b9a000b7d5968 |
|
Deploy preview for carbon-elements ready! Built with commit 01a823b |
emyarod
approved these changes
Oct 14, 2019
jnm2377
approved these changes
Oct 14, 2019
joshblack
approved these changes
Oct 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4161
This PR updates
flex: 1to beflex: 1 1 auto.flex: 1was causing the --form-item to collapse within the pagination component in IE11.flex: 1is equivalent toflex: 1 1 0, which sets the flex-basis to 0, this is fine in most browsers. However in IE11, this only works when the flex container usesflex-direction: row. Forflex-direction: column, children will overlap as if they would not consume any height.This PR also updates
top: autototop: 50%, and removedbottom: auto. Addedtransform: translateY(-50%)as this will center the position absolute svg in a flex container in IE11.align-items: centerwill not center a flex child that hasposition: absoluteset in IE11.Changelog
New
transform: translateY(-50%)on#{$prefix}--pagination .#{$prefix}--select__arrowChanged
Update
flex: 1to beflex: 1 1 autoon#{$prefix}--form-itemUpdate
top: autototop: 50%on#{$prefix}--pagination .#{$prefix}--select__arrowRemoved
bottom: autoon#{$prefix}--pagination .#{$prefix}--select__arrowTesting / Reviewing