fix(datepicker): add top offset to fix vertical icon alignment IE11 #4235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Deploy preview for the-carbon-components ready! Built with commit a27d2a3 https://deploy-preview-4235--the-carbon-components.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit a27d2a3 |
|
Deploy preview for carbon-components-react ready! Built with commit a27d2a3 https://deploy-preview-4235--carbon-components-react.netlify.com |
chrisconnors-ibm
requested review from
designertyler and
laurenmrice
and removed request for
mjabbink
dakahn
approved these changes
Oct 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2061
This PR adds a top offset of 50% with transform: translateY(-50%), to vertically center the datepicker icon in IE11.
position: relativeis also added todate-picker-input__wrapper, so then--date-picker__iconwill be positioned relative todate-picker-input__wrapperwhich will now be its nearest positioned ancestor.Changelog
New
position: relativetodate-picker-input__wrapperto position--date-picker__iconrelative todate-picker-input__wrapper.--date-picker__iconto vertically center datepicker icon in IE11.Testing / Reviewing