fix(ComboBox): removes all DAP violations #4201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshblack
approved these changes
Oct 3, 2019
|
Deploy preview for carbon-elements failed. Built with commit 12d75be https://app.netlify.com/sites/carbon-elements/deploys/5d9d1c5cbfd7450008af7d3c |
|
Deploy preview for the-carbon-components ready! Built with commit 12d75be https://deploy-preview-4201--the-carbon-components.netlify.com |
|
Deploy preview for carbon-components-react ready! Built with commit 12d75be https://deploy-preview-4201--carbon-components-react.netlify.com |
dakahn
approved these changes
Oct 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Finally) Closes #3260
Adds isOpen check in
aria-ownsandaria-controlsoninputso that it is null if the dropdown is closed. Also changes the color of the numbers in the "items as components' story so it doesn't fail a color contrast check.Changelog
Changed
Testing / Reviewing
Run DAP on the open and closed Combobox and confirm that there are no violations.