Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(postmortem): add icons-angular v10.5.0 incident #3749

Merged
merged 6 commits into from
Aug 16, 2019
Merged

docs(postmortem): add icons-angular v10.5.0 incident #3749

merged 6 commits into from
Aug 16, 2019

Conversation

joshblack
Copy link
Contributor

Add in postmortem process an initial document for @carbon/icons-angular incident

Changelog

New

  • Add README.md for postmortem folder
  • Add incident report for @carbon/icons-angular

Changed

  • on-windows-hcm-support.md moved back to docs
  • post-mortems -> postmortems

Removed

@joshblack joshblack requested a review from a team August 16, 2019 00:58
@ghost ghost requested review from abbeyhrt and tw15egan and removed request for a team August 16, 2019 00:58
@netlify
Copy link

netlify bot commented Aug 16, 2019

Deploy preview for the-carbon-components ready!

Built with commit 79d55a3

https://deploy-preview-3749--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Aug 16, 2019

Deploy preview for carbon-elements ready!

Built with commit 79d55a3

https://deploy-preview-3749--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Aug 16, 2019

Deploy preview for carbon-components-react ready!

Built with commit 79d55a3

https://deploy-preview-3749--carbon-components-react.netlify.com

@netlify
Copy link

netlify bot commented Aug 16, 2019 •
edited
Loading

Deploy preview for the-carbon-components ready!

Built with commit 3bae3d6

https://deploy-preview-3749--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Aug 16, 2019 •
edited
Loading

Deploy preview for carbon-elements ready!

Built with commit 3bae3d6

https://deploy-preview-3749--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Aug 16, 2019 •
edited
Loading

Deploy preview for carbon-components-react ready!

Built with commit 3bae3d6

https://deploy-preview-3749--carbon-components-react.netlify.com

emyarod
emyarod approved these changes Aug 16, 2019
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! just a couple notes

docs/postmortems/00-template.md Outdated Show resolved Hide resolved
docs/postmortems/00-template.md Outdated

**Summary**

Ipsum culpa molestias doloribus modi veniam ipsa Voluptatem voluptatum error
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe instead of lorem ipsum we can help people fill these sections out by providing questions or comments like in our issue and PR templates

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On it!

cal-smith
cal-smith approved these changes Aug 16, 2019
View reviewed changes
Copy link
Contributor

@cal-smith cal-smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing this up @joshblack, and for sorting out the situation quickly 💯

Cases like this should be rare, but I wonder if there's some post-build, pre-deploy, sanity checks that would help ... in this case a general file structure validation would have been enough to trigger a warning.

Ideally this is something our upgrade tooling could catch, but we're just not there yet.

@joshblack
Copy link
Contributor Author

@cal-smith part of me wants to just define full end-to-end workflows with verdaccio and publish and run some kind of install check. For example, on the React side we manually use create-react-app for some smoke tests to make sure it can build/compile.

abbeyhrt
abbeyhrt approved these changes Aug 16, 2019
View reviewed changes
Copy link
Contributor

@abbeyhrt abbeyhrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and seems like a great idea going forward! 🎉

@joshblack joshblack merged commit c614279 into carbon-design-system:master Aug 16, 2019
@joshblack joshblack deleted the docs/add-icons-angular-10.5-postmortem branch August 16, 2019 16:05
@cal-smith
Copy link
Contributor

part of me wants to just define full end-to-end workflows with verdaccio and publish and run some kind of install check. For example, on the React side we manually use create-react-app for some smoke tests to make sure it can build/compile.

@joshblack Whoa, that sounds fantastic ... I'll have to poke around to see how that works ... I'll be in touch haha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cal-smith cal-smith cal-smith approved these changes

@emyarod emyarod emyarod approved these changes

@abbeyhrt abbeyhrt abbeyhrt approved these changes

@tw15egan tw15egan Awaiting requested review from tw15egan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joshblack @cal-smith @emyarod @abbeyhrt