Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ComboBox): switch from onInputValueChange to onStateChange #3646

Merged
merged 2 commits into from
Aug 5, 2019
Merged

fix(ComboBox): switch from onInputValueChange to onStateChange #3646

merged 2 commits into from
Aug 5, 2019

Commits on Aug 5, 2019

  1. fix(ComboBox): switch from onInputValueChange to onStateChange 

    Downshift `v1`'s `onInputValueChange` seems to be called from React
state updater function and thus calling `setState()` in
`onInputValueChange` handler causes React's "An update was scheduled
from inside an update function" warning.

Fixes carbon-design-system#2543.
Fixes carbon-design-system#3637.
    Akira Sudoh committed Aug 5, 2019
    Configuration menu
    Copy the full SHA
    a566b61 View commit details
    Browse the repository at this point in the history

  2. test(ComboBox): update upon new internal API

    @asudoh
    asudoh committed Aug 5, 2019
    Configuration menu
    Copy the full SHA
    fa146e9 View commit details
    Browse the repository at this point in the history