-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(list-box): replace value
attribute selectors
#3411
Merged
asudoh
merged 12 commits into
carbon-design-system:master
from
emyarod:3290-combobox-styling-framework-agnostic
Oct 11, 2019
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
64fff09
fix(css-reset): use Plex for all inputs
emyarod 82d4f20
refactor(list-box): replace value attr selectors
emyarod 3d90e7b
fix(list-box): remove inline disabled hover background
emyarod 30a0e03
Merge branch 'master' into 3290-combobox-styling-framework-agnostic
vpicone 3033496
Merge branch 'master' into 3290-combobox-styling-framework-agnostic
joshblack 653d2ca
Merge branch 'master' into 3290-combobox-styling-framework-agnostic
jnm2377 cd1799c
Merge branch 'master' into 3290-combobox-styling-framework-agnostic
jnm2377 b7f520d
Merge branch 'master' into 3290-combobox-styling-framework-agnostic
jnm2377 e8e31e6
Merge branch 'master' into 3290-combobox-styling-framework-agnostic
asudoh 0d69838
Merge branch 'master' into 3290-combobox-styling-framework-agnostic
asudoh a4d11b9
Merge branch 'master' into 3290-combobox-styling-framework-agnostic
asudoh d331405
Merge branch 'master' into 3290-combobox-styling-framework-agnostic
asudoh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@emyarod Is this intentional? Asking because it seems to change the specificity of the reset style for
<input>
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@asudoh yes, in order to override browser user agent styles
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, is it needed to complete this PR or was it just an issue you found?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since this is only a style change it's not needed to resolve the original issue but we will need to make this change so that the component uses the correct font
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK sounds fair enough - Thanks for clarifying!