Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pagination): focus buttons web components #18165

Conversation

ariellalgilmore
Copy link
Member

Closes #17767 (Web components)

pagination not resetting focus when reaching the end of the foward/previous buttons

Changelog

Changed

  • updated to reset focus
  • added padding: 0; so buttons aren't getting pushed

Testing / Reviewing

go to Web components storybook

  • pagination story
  • click or tab/enter on the forward/previous buttons and make sure the focus is properly updated at the beginning at the end and beginning

@ariellalgilmore ariellalgilmore requested a review from a team as a code owner November 27, 2024 01:15
@ariellalgilmore ariellalgilmore added the package: @carbon/web-components @carbon/web-components label Nov 27, 2024
Copy link

netlify bot commented Nov 27, 2024

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit a0e097f
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/674672c8b6839300089378c6
😎 Deploy Preview https://deploy-preview-18165--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 27, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit a0e097f
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/674672c8448c0a0008a5f1a0
😎 Deploy Preview https://deploy-preview-18165--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 27, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit a0e097f
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/674672c844923d00087042bd
😎 Deploy Preview https://deploy-preview-18165--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.36%. Comparing base (f2ba3fd) to head (a0e097f).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18165      +/-   ##
==========================================
+ Coverage   83.22%   83.36%   +0.13%     
==========================================
  Files         404      404              
  Lines       14338    14344       +6     
  Branches     4645     4616      -29     
==========================================
+ Hits        11933    11958      +25     
+ Misses       2243     2224      -19     
  Partials      162      162              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@annawen1 annawen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected, LGTM!

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tay1orjones tay1orjones added this pull request to the merge queue Dec 3, 2024
Merged via the queue into carbon-design-system:main with commit 7016a95 Dec 3, 2024
40 checks passed
@carbon-automation
Copy link
Contributor

Hey there! v11.72.0 was just released that references this issue/PR.

@ariellalgilmore ariellalgilmore deleted the fix/pagination-focus-web-components branch December 5, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Next and previous buttons in cds-pagination are violating a11y rules.
3 participants