-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pagination): focus buttons web components #18165
fix(pagination): focus buttons web components #18165
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18165 +/- ##
==========================================
+ Coverage 83.22% 83.36% +0.13%
==========================================
Files 404 404
Lines 14338 14344 +6
Branches 4645 4616 -29
==========================================
+ Hits 11933 11958 +25
+ Misses 2243 2224 -19
Partials 162 162 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working as expected, LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
7016a95
Hey there! v11.72.0 was just released that references this issue/PR. |
Closes #17767 (Web components)
pagination not resetting focus when reaching the end of the foward/previous buttons
Changelog
Changed
Testing / Reviewing
go to Web components storybook