Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(modal-wrapper): increase coverage #18156

Conversation

ariellalgilmore
Copy link
Member

Closes #17485

Increase coverage for modal wrapper

Changelog

Changed

  • check for onkeydown with escape press
  • added shouldCloseAfterSubmit when submitting the modalWrapper

Testing / Reviewing

Check codecov increases

@ariellalgilmore ariellalgilmore requested a review from a team as a code owner November 25, 2024 19:14
Copy link

netlify bot commented Nov 25, 2024

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 41a31d3
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/674d6fabae812f0008df762f
😎 Deploy Preview https://deploy-preview-18156--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 25, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 41a31d3
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/674d6fab809b080008bb66c8
😎 Deploy Preview https://deploy-preview-18156--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 25, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 41a31d3
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/674d6faba1ee31000829580d
😎 Deploy Preview https://deploy-preview-18156--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@2nikhiltom 2nikhiltom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.41%. Comparing base (29d0f18) to head (41a31d3).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18156      +/-   ##
==========================================
+ Coverage   83.36%   83.41%   +0.04%     
==========================================
  Files         404      404              
  Lines       14344    14344              
  Branches     4650     4596      -54     
==========================================
+ Hits        11958    11965       +7     
+ Misses       2224     2218       -6     
+ Partials      162      161       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@annawen1 annawen1 added this pull request to the merge queue Dec 3, 2024
Merged via the queue into carbon-design-system:main with commit cdf16cd Dec 3, 2024
40 checks passed
@carbon-automation
Copy link
Contributor

Hey there! v11.72.0 was just released that references this issue/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase ModalWrapper unit test coverage
4 participants