-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(modal-wrapper): increase coverage #18156
test(modal-wrapper): increase coverage #18156
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18156 +/- ##
==========================================
+ Coverage 83.36% 83.41% +0.04%
==========================================
Files 404 404
Lines 14344 14344
Branches 4650 4596 -54
==========================================
+ Hits 11958 11965 +7
+ Misses 2224 2218 -6
+ Partials 162 161 -1 ☔ View full report in Codecov by Sentry. |
cdf16cd
Hey there! v11.72.0 was just released that references this issue/PR. |
Closes #17485
Increase coverage for modal wrapper
Changelog
Changed
Testing / Reviewing
Check codecov increases