Fix SelectableTile typescript declaration for "value". #18143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I previously fixed PropTypes but forgot to update the Typescript declaration. Fixes carbon-design-system#16977. Refs carbon-design-system#13537, carbon-design-system#13631.
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18143 +/- ##
=======================================
Coverage 82.87% 82.87%
=======================================
Files 404 404
Lines 14338 14338
Branches 4591 4591
=======================================
Hits 11882 11882
Misses 2296 2296
Partials 160 160 ☔ View full report in Codecov by Sentry. |
|
As usual, this is getting visual diffs, but presumably they are unrelated to my PR. (Same thing happened on the last PR.) |
ariellalgilmore
approved these changes
Nov 25, 2024
Gururajj77
approved these changes
Nov 26, 2024
alisonjoseph
approved these changes
Dec 3, 2024
Merged
via the queue into
carbon-design-system:main
with commit Dec 3, 2024
05b6a4e
40 checks passed
|
Hey there! v11.72.0 was just released that references this issue/PR. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16977
I previously fixed PropTypes but forgot to update the Typescript declaration.
Changelog
Changed
Testing / Reviewing
Tested locally.