-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(select): add new decorator prop #18107
feat(select): add new decorator prop #18107
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18107 +/- ##
==========================================
+ Coverage 82.29% 82.65% +0.35%
==========================================
Files 404 404
Lines 14276 14308 +32
Branches 4531 4615 +84
==========================================
+ Hits 11749 11826 +77
+ Misses 2365 2321 -44
+ Partials 162 161 -1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎉 🎉 🎉
ab1861d
Closes #17997
Add
decorator
prop toSelect
andFluidSelect
, deprecateslug
propFix style bugs with "revert" functionality in invalid/warn state
Fix AILabel style bug in FluidSelect
Changelog
New
Changed
Testing / Reviewing
Review stories for...
Select > with AI Label
Form > with AI Label
FluidSelect > with AI Label
Remove test data from storybook