Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(select): add new decorator prop #18107

Merged
merged 21 commits into from
Nov 21, 2024

Conversation

alisonjoseph
Copy link
Member

@alisonjoseph alisonjoseph commented Nov 18, 2024

Closes #17997

Add decorator prop to Select and FluidSelect, deprecate slug prop
Fix style bugs with "revert" functionality in invalid/warn state
Fix AILabel style bug in FluidSelect

Changelog

New

  • New decorator prop for Select & FluidSelect
  • Add with AILabel story to FluidSelect

Changed

  • Deprecate slug prop for Select & FluidSelect
  • Updated styles for select to ensure proper alignment with all combination of states. Invalid, warn, revert
  • Update styles for FluidSelect so AILabel is correctly placed

Testing / Reviewing

Review stories for...

  • Select > with AI Label

  • Form > with AI Label

  • FluidSelect > with AI Label

  • Remove test data from storybook

Copy link

netlify bot commented Nov 18, 2024

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 0a3441d
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/673f46d182088100084d9935
😎 Deploy Preview https://deploy-preview-18107--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 18, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 0a3441d
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/673f46d1d3baaa0008e090fe
😎 Deploy Preview https://deploy-preview-18107--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 18, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 0a3441d
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/673f46d14802fa00082e3c9f
😎 Deploy Preview https://deploy-preview-18107--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.65%. Comparing base (b53f566) to head (0a3441d).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18107      +/-   ##
==========================================
+ Coverage   82.29%   82.65%   +0.35%     
==========================================
  Files         404      404              
  Lines       14276    14308      +32     
  Branches     4531     4615      +84     
==========================================
+ Hits        11749    11826      +77     
+ Misses       2365     2321      -44     
+ Partials      162      161       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@alisonjoseph alisonjoseph changed the title Select decorator feat(select): add new decorator prop Nov 19, 2024
@alisonjoseph alisonjoseph marked this pull request as ready for review November 19, 2024 18:33
@alisonjoseph alisonjoseph requested review from a team as code owners November 19, 2024 18:33
Copy link
Member

@ariellalgilmore ariellalgilmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉 🎉 🎉

@alisonjoseph alisonjoseph added this pull request to the merge queue Nov 21, 2024
Merged via the queue into carbon-design-system:main with commit ab1861d Nov 21, 2024
40 checks passed
@alisonjoseph alisonjoseph deleted the select-decorator branch November 21, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decorator: Select
3 participants