Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added export to selectprops interface #18106

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

guidari
Copy link
Contributor

@guidari guidari commented Nov 18, 2024

Closes #16545

Exporting the SelectProps interface

Testing / Reviewing

  • Users should be able to use the interface

Copy link

netlify bot commented Nov 18, 2024

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit bed0a76
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/673c22e7f995480008706964
😎 Deploy Preview https://deploy-preview-18106--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 18, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit bed0a76
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/673c22e7c4c0aa000872b178
😎 Deploy Preview https://deploy-preview-18106--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 18, 2024

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit bed0a76
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/673c22e7caee470008b79f3b
😎 Deploy Preview https://deploy-preview-18106--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.21%. Comparing base (4fb87e7) to head (bed0a76).
Report is 20 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18106   +/-   ##
=======================================
  Coverage   82.21%   82.21%           
=======================================
  Files         404      404           
  Lines       14200    14200           
  Branches     4509     4459   -50     
=======================================
  Hits        11674    11674           
  Misses       2364     2364           
  Partials      162      162           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@annawen1 annawen1 enabled auto-merge November 18, 2024 18:59
@annawen1 annawen1 added this pull request to the merge queue Nov 21, 2024
Merged via the queue into carbon-design-system:main with commit b2ef6ff Nov 21, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typescript : SelectProps interface is not exported
4 participants