fix(button): center align ghost button icons #18076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18076 +/- ##
=======================================
Coverage 82.14% 82.14%
=======================================
Files 404 404
Lines 14117 14117
Branches 4434 4404 -30
=======================================
Hits 11597 11597
+ Misses 2359 2358 -1
- Partials 161 162 +1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
tay1orjones
approved these changes
Nov 15, 2024
ariellalgilmore
approved these changes
Nov 15, 2024
ariellalgilmore
added
status: ready to merge 🎉
and removed
status: one more review 👀
labels
riddhybansal
approved these changes
Nov 17, 2024
Merged
via the queue into
carbon-design-system:main
with commit Nov 21, 2024
5da347d
40 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17082
this PR updates the ghost button icons to be center aligned