feat: replace slug with decorator ComboBox, MultiSelect, FilterableMultiSelect #18069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
alisonjoseph
changed the title
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
alisonjoseph
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18069 +/- ##
==========================================
+ Coverage 82.21% 82.24% +0.03%
==========================================
Files 404 404
Lines 14200 14230 +30
Branches 4509 4489 -20
==========================================
+ Hits 11674 11704 +30
Misses 2364 2364
Partials 162 162 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
ariellalgilmore
approved these changes
Nov 15, 2024
emyarod
approved these changes
Nov 18, 2024
kennylam
approved these changes
Nov 19, 2024
tay1orjones
approved these changes
Nov 20, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
via the queue into
carbon-design-system:main
with commit Nov 21, 2024
c52884c
40 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17989
Closes #17996
Changelog
New
Changed
Testing / Reviewing
Check ComboBox with AILabel storybook
Check MultiSelect with AILabel storybook
Check FilterableMultiSelect with AILabel storybook
TODO:remove test content from storybook