feat(popover): add autoAlignBoundary for configurable collision boundary
#16995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tay1orjones
commented
Jul 18, 2024
| borderColor: 'black', | ||
| margin: '0 auto', | ||
| }} | ||
| ref={setBoundary}> |
There was a problem hiding this comment.
TIL how this pattern works: https://www.youtube.com/watch?v=leEdHQh6nP8
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…nfigurable-collision-boundary
…nfigurable-collision-boundary
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…nfigurable-collision-boundary
…nfigurable-collision-boundary
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16995 +/- ##
==========================================
+ Coverage 82.21% 82.68% +0.47%
==========================================
Files 404 404
Lines 14200 14338 +138
Branches 4509 4641 +132
==========================================
+ Hits 11674 11856 +182
+ Misses 2363 2321 -42
+ Partials 163 161 -2 ☔ View full report in Codecov by Sentry. |
tay1orjones
requested review from
kennylam,
emyarod,
alisonjoseph and
ariellalgilmore
and removed request for
kennylam and
emyarod
ariellalgilmore
approved these changes
Nov 21, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 2, 2024
…ndary (#16995) * feat(popover): add autoAlignBoundary for configurable collision boundary * chore: yarn format * fix(popover): improve autoAlignBoundary proptype * fix(popover): ensure popover conforms to popovercomponent * chore: update snaps
tay1orjones
added
status: ready to merge 🎉
and removed
status: ready for review 👀
labels
Merged
via the queue into
carbon-design-system:main
with commit Dec 2, 2024
dec8173
40 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16879
Closes #16982
Relies on #17139
This adds a new prop that enables consumers to configure what element is used in the overflow detection for
autoAlignvia floating-ui. The new storybook example shows a custom boundary element (marked by a dashed border). The popover repositions based on this element, rather than the viewport.Changelog
New
autoAlignBoundaryto PopoverTesting / Reviewing