Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Onboard @carbon/react to IBM Telemetry 🚀 #15390

Merged
merged 8 commits into from
Dec 14, 2023

Conversation

francinelucca
Copy link
Collaborator

  • Uninstall @carbon/telemetry from @carbon/react
  • Add telemetry.yml config file
  • Update postinstall script to call new telemetry script, remove legacy script call
  • Add IBM Telemetry collection disclosure to README

@francinelucca francinelucca changed the title Chore: Onboard @carbon/react to IBM Telemetry Chore: Onboard @carbon/react to IBM Telemetry 🚀 Dec 13, 2023
Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🙌 🚀

Copy link

netlify bot commented Dec 13, 2023

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 14dcca4
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/657a17c44d16ff0008a821fd
😎 Deploy Preview https://deploy-preview-15390--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tay1orjones
Copy link
Member

I'd like to get this same change made to the v10 branch. We can do it, or you, just let me know.

Copy link

netlify bot commented Dec 13, 2023

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit b34667f
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/657a2c96bcd38c00081716a4
😎 Deploy Preview https://deploy-preview-15390--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -0,0 +1,815 @@
# yaml-language-server: $schema=https://unpkg.com/@ibm/telemetry-config-schema@v0/dist/config.schema.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This config was generated with a script by @francinelucca to get all prop and prop values that we want to collect. We're still finishing the script to use when instrumenting other packages. Once that script is done, maybe we could add that to a CI/CD script to automate this config's upkeep as components, component props, and supported component prop values change.

@mattrosno
Copy link
Member

I'd like to get this same change made to the v10 branch. We can do it, or you, just let me know.

@tay1orjones let's instrument v11 first, then we can look at the v10 branch. We'll need to generate the allowed telemetry prop config for the v10 branch.

@francinelucca francinelucca added this pull request to the merge queue Dec 14, 2023
Merged via the queue into main with commit 14c2b7e Dec 14, 2023
20 checks passed
@francinelucca francinelucca deleted the chore/create-telemetry-config-file branch December 14, 2023 18:18
danoro96 pushed a commit to danoro96/carbon that referenced this pull request Jan 18, 2024
…#15390)

* chore: add telemetry.yml config file

* chore: remove HTML attr from telemetry.yml, add ref to React attrs

* chore: onboard @carbon/react to IBM telemetry

* chore: add telemetry.yml to files

* fix: telemetry.yml path correction

* fix: sort telemetry.yml keys and wrap around single quotes

* fix: point schema version to v1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants