-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Onboard @carbon/react to IBM Telemetry 🚀 #15390
Conversation
…ore/create-telemetry-config-file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 🙌 🚀
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I'd like to get this same change made to the v10 branch. We can do it, or you, just let me know. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
packages/react/telemetry.yml
Outdated
@@ -0,0 +1,815 @@ | |||
# yaml-language-server: $schema=https://unpkg.com/@ibm/telemetry-config-schema@v0/dist/config.schema.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This config was generated with a script by @francinelucca to get all prop and prop values that we want to collect. We're still finishing the script to use when instrumenting other packages. Once that script is done, maybe we could add that to a CI/CD script to automate this config's upkeep as components, component props, and supported component prop values change.
@tay1orjones let's instrument v11 first, then we can look at the v10 branch. We'll need to generate the allowed telemetry prop config for the v10 branch. |
…#15390) * chore: add telemetry.yml config file * chore: remove HTML attr from telemetry.yml, add ref to React attrs * chore: onboard @carbon/react to IBM telemetry * chore: add telemetry.yml to files * fix: telemetry.yml path correction * fix: sort telemetry.yml keys and wrap around single quotes * fix: point schema version to v1
telemetry.yml
config file