feat(icons): rename infinity to infinity-symbol #15384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
guidari
approved these changes
Dec 13, 2023
2 tasks
tay1orjones
approved these changes
Dec 13, 2023
alisonjoseph
added
status: visual review 🔍
and removed
status: ready for review 👀
labels
laurenmrice
approved these changes
Dec 14, 2023
Merged
via the queue into
carbon-design-system:main
with commit Dec 14, 2023
3948cd3
24 checks passed
danoro96
pushed a commit
to danoro96/carbon
that referenced
this pull request
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15306
We need to rename the inifity icon because
Infinityis a global property in javascript which causes errors when we try and export it as a component with the same name https://www.w3schools.com/jsref/jsref_infinity.aspChangelog
Changed
infinityicon toinfinity-symbolTesting / Reviewing
confirmed with @conradennis they're good with the name update ✅