Reconfigure UI Shell #14127
Merged
Reconfigure UI Shell #14127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
guidari
requested review from
tw15egan,
andreancardona,
a team and
aubrey-oneal
and removed request for
a team
tay1orjones
approved these changes
Jul 5, 2023
packages/react/src/components/UIShell/UIShell.HeaderBase.stories.js
Outdated
Show resolved
Hide resolved
andreancardona
approved these changes
Jul 5, 2023
tay1orjones
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13419
This PR was created to fix the merge conflicts from the old PR #14088
After the meeting with @tay1orjones, @laurenmrice, and @jeanservaas, we reached a few conclusions regarding the necessary reconfigurations for the UI Shell.
Changed
Headercomponent on these stories Fixed SideNav, Fixed SideNav w/ Divider, Fixed SideNav w/ Icons, SideNav w/ large side nav itemsStoryContentto all the storiesRemoved
These stories below were removed
Testing / Reviewing
Make sure the stories are working fine. There shouldn't be any changes on the functionalites.