Skip to content

feat(react): added input change callback to multiselect filterable #11415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 17, 2022
Merged

feat(react): added input change callback to multiselect filterable #11415

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
bcd9686
feat(react): added input change callback to multiselect filterable
TannerS May 13, 2022
098f214
chore(react): removed story changes for previous version
TannerS May 13, 2022
f1021c7
Merge branch 'main' into tanner_addInputChangeMultiselectProp
TannerS May 13, 2022
65f116f
chore(project): update snaps
tay1orjones May 13, 2022
47095c7
Merge branch 'main' into tanner_addInputChangeMultiselectProp
kodiakhq[bot] May 17, 2022
a143a46
chore(react): updated handleOnInputValueChange to remove type param
TannerS May 17, 2022
80c7351
Merge branch 'tanner_addInputChangeMultiselectProp' of github.com:Tan…
TannerS May 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/react/__tests__/__snapshots__/PublicAPI-test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3154,6 +3154,9 @@ Map {
"onChange": Object {
"type": "func",
},
"onInputValueChange": Object {
"type": "func",
},
"onMenuChange": Object {
"type": "func",
},
Expand Down Expand Up @@ -4339,6 +4342,9 @@ Map {
"onChange": Object {
"type": "func",
},
"onInputValueChange": Object {
"type": "func",
},
"onMenuChange": Object {
"type": "func",
},
Expand Down
10 changes: 10 additions & 0 deletions packages/react/src/components/MultiSelect/FilterableMultiSelect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,12 @@ export default class FilterableMultiSelect extends React.Component {
*/
onChange: PropTypes.func,

/**
* `onInputValueChange` is a utility for this controlled component to communicate to
* the currently typed input.
*/
onInputValueChange: PropTypes.func,

/**
* `onMenuChange` is a utility for this controlled component to communicate to a
* consuming component that the menu was opened(`true`)/closed(`false`).
Expand Down Expand Up @@ -259,6 +265,10 @@ export default class FilterableMultiSelect extends React.Component {
};

handleOnInputValueChange = (inputValue, { type }) => {
if (this.props.onInputValueChange) {
this.props.onInputValueChange(inputValue, { type });
}

if (type !== Downshift.stateChangeTypes.changeInput) {
return;
}
Expand Down
11 changes: 11 additions & 0 deletions packages/react/src/components/MultiSelect/next/FilterableMultiSelect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ const FilterableMultiSelect = React.forwardRef(function FilterableMultiSelect(
itemToString,
light,
locale,
onInputValueChange,
open,
onChange,
onMenuChange,
Expand Down Expand Up @@ -165,6 +166,10 @@ const FilterableMultiSelect = React.forwardRef(function FilterableMultiSelect(
}

function handleOnInputValueChange(inputValue, { type }) {
if (onInputValueChange) {
onInputValueChange(inputValue, { type });
}

if (type !== Downshift.stateChangeTypes.changeInput) {
return;
}
Expand Down Expand Up @@ -515,6 +520,12 @@ FilterableMultiSelect.propTypes = {
*/
onChange: PropTypes.func,

/**
* `onInputValueChange` is a utility for this controlled component to communicate to
* the currently typed input.
*/
onInputValueChange: PropTypes.func,

/**
* `onMenuChange` is a utility for this controlled component to communicate to a
* consuming component that the menu was opened(`true`)/closed(`false`).
Expand Down