-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(React): remove deprecated v11 props #11104
fix(React): remove deprecated v11 props #11104
Conversation
Didn't touch datepickerinput and modal (designated that above) because as per the instructions they had corresponding /next files 👍🏾 |
✅ Deploy Preview for carbon-components-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, just left a refactor note
packages/react/src/components/DatePickerInput/next/DatePickerInput.js
Outdated
Show resolved
Hide resolved
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@dakahn @tay1orjones one thing I noticed is that the VRT for button changed. Is this the correct change for the size prop updates? |
@joshblack @dakahn my guess is that the vrt test needs to be updated to use the correct/new @sstrubberg did you run into problems with button sizes when doing #10532 ? |
…18-remove-deprecated-code
Closes #11082
Remove deprecated in v11 props from the following files:
partially closes #8418
Accordion/Accordion.Skeleton.js
Accordion/AccordionItem.js
Button/Button.js
Checkbox/Checkbox.js
ContentSwitcher/ContentSwitcher.js
DataTable/Table.js
DataTable/TableExpandHeader.js
DataTable/TableToolbarSearch.js
DatePickerInput/DatePickerInput.js
DatePickerInput/next/DatePickerInput.js
Dropdown/Dropdown.js
Dropdown/Dropdown.Skeleton.js
InlineLoading/InlineLoading.js
Modal/Modal.js
Modal/next/Modal.js