feat(progress-bar): add "small" size variant #10708
Conversation
|
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: 5f0264c 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/620ffa23a9b8870007074f4f 😎 Browse the preview: https://deploy-preview-10708--carbon-react-next.netlify.app |
|
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 5f0264c 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/620ffa2347456d000766659c 😎 Browse the preview: https://deploy-preview-10708--carbon-elements.netlify.app |
|
❌ Deploy Preview for carbon-components-react failed. 🔨 Explore the source changes: 9d2d38f 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6206657dfb710a0008b743d7 |
|
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 5f0264c 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/620ffa236b6e9000076c8ae9 😎 Browse the preview: https://deploy-preview-10708--carbon-components-react.netlify.app |
|
@aagonzales what do you think about |
I believe this is still true in v11. It should be using |
|
It says the sizes but there no button to actually change the size. How do you turn the small size on? (i noticed this happening in a lot of stories) |
|
@aagonzales Ah yeah, sorry about that. In the new storybook we need to add in controls. Storybook deprecated the knobs addon we use in the v10 storybook, so many stories in the v11 storybook don't have controls. It's going to be addressed this sprint in #10751 The v10 storybook has a knob though to view these changes https://deploy-preview-10708--carbon-components-react.netlify.app/?path=/story/experimental-unstable-progressbar--playground |
…tem#10708) * fix(ghost-button): icon alignment for larger sizes * fix(button): format --------- Co-authored-by: Anna Wen <[email protected]>
Ref #10670
Adds a new prop (
size) to theProgressBarcomponent and adds the styling necessary to render atsmallsize (4px height).Changelog
New
props.sizetoProgressBarTesting / Reviewing
Verify in storybook that "big" variant is 8px high and "small" 4px.
Question regarding the prop values: As I understand components that don't fit the classic t-shirt size names like Tag, Toggle and ProgressBar should be referred to as "big" and "small". So far, the two other components still use
smandmdas their prop values. With v11, will this be changed or should I change the prop values for ProgressBar also tosmandmdfor now?