-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react): added hideLegend prop to RadioButtonGroup #10682
feat(react): added hideLegend prop to RadioButtonGroup #10682
Conversation
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: 9d21a5d 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/620bd2d75f5aba00081a4753 😎 Browse the preview: https://deploy-preview-10682--carbon-react-next.netlify.app |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 9d21a5d 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/620bd2d7fe03750007510c6b 😎 Browse the preview: https://deploy-preview-10682--carbon-elements.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 9d21a5d 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/620bd2d7d1ea4b0008ed8bd7 😎 Browse the preview: https://deploy-preview-10682--carbon-components-react.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Able to hide the legend and not get any a11y violations 👍🏻 ✅ 🎉
Closes #
Changelog
New
hideLegend
prop to hide theRadioButtonGroup
legend to fix an a11y issue.Testing / Reviewing