Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react): added hideLegend prop to RadioButtonGroup #10682

Conversation

TannerS
Copy link
Contributor

@TannerS TannerS commented Feb 10, 2022

Closes #

Changelog

New

  • Added hideLegend prop to hide the RadioButtonGroup legend to fix an a11y issue.

Testing / Reviewing

  • Tested in local storybook using IBM a11y tool

@netlify
Copy link

netlify bot commented Feb 10, 2022

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 9d21a5d

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/620bd2d75f5aba00081a4753

😎 Browse the preview: https://deploy-preview-10682--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Feb 10, 2022

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 9d21a5d

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/620bd2d7fe03750007510c6b

😎 Browse the preview: https://deploy-preview-10682--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Feb 10, 2022

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 9d21a5d

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/620bd2d7d1ea4b0008ed8bd7

😎 Browse the preview: https://deploy-preview-10682--carbon-components-react.netlify.app

Copy link
Member

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Able to hide the legend and not get any a11y violations 👍🏻 ✅ 🎉

@kodiakhq kodiakhq bot merged commit a31bb94 into carbon-design-system:main Feb 15, 2022
@TannerS TannerS deleted the tanner_addLegendDisablePropRadioButton branch February 21, 2022 19:02
@jnm2377 jnm2377 mentioned this pull request Feb 22, 2022
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants