Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(stylelint): update stylelint to 14.3.0 #10637

Merged
merged 11 commits into from
Feb 15, 2022

Conversation

tw15egan
Copy link
Member

@tw15egan tw15egan commented Feb 3, 2022

Noticed there was a message about stylelint v13 being deprecated in VSCode, so I've gone and updated us to v14.3.0.

Screen Shot 2022-02-03 at 2 43 45 PM

Reference:

Migration:

Changelog

New

  • stylelint now extends stylelint-config-standard-scss

Changed

  • Upgraded stylelint from 13.13 to 14.3

Testing / Reviewing

Ensure no warning pops up in the bottom right corner of VS Code when opening the Carbon repo.
Ensure stylelint validations still appear as usual

@tw15egan
Copy link
Member Author

tw15egan commented Feb 3, 2022

Note for reviewers: Do we want to disable the rules that are now throwing lint errors?

@joshblack
Copy link
Contributor

@tw15egan great point, I think some of them may need to be configured per-directory, like:
scss/no-global-function-names should be disabled in components but enabled in styles

scss/comment-no-empty seems like one we can definitely disable

For ones that are unknown, definitely feel free to remove them (like function-calc-no-invalid) if there is no replacement in the new version

@netlify
Copy link

netlify bot commented Feb 3, 2022

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 3f9fb43

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/620bea684e80040008edeab1

😎 Browse the preview: https://deploy-preview-10637--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Feb 3, 2022

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 3f9fb43

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/620bea6811e5b50008cc2f1f

😎 Browse the preview: https://deploy-preview-10637--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Feb 3, 2022

✔️ Deploy Preview for carbon-components-react ready!

🔨 Explore the source changes: 9cd5c08

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61fc42881e903c00077dda5a

😎 Browse the preview: https://deploy-preview-10637--carbon-components-react.netlify.app/

@tw15egan
Copy link
Member Author

tw15egan commented Feb 3, 2022

@joshblack do you have any examples on how to disable in one package but not the others? Would that be made in config/stylelint, or in the components repo itself?

@joshblack
Copy link
Contributor

@tw15egan I think we would use overrides for this: https://stylelint.io/user-guide/configure#overrides

Let me know if that works!

@netlify
Copy link

netlify bot commented Feb 3, 2022

✔️ Deploy Preview for carbon-components-react ready!

🔨 Explore the source changes: 3f9fb43

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/620bea6867eaf80007a2cfab

😎 Browse the preview: https://deploy-preview-10637--carbon-components-react.netlify.app

@tw15egan
Copy link
Member Author

tw15egan commented Feb 8, 2022

@joshblack Got it worked out, good to go now if you want to take another look

@@ -330,11 +330,11 @@ $button-disabled: (
),
(
theme: themes.$g90,
value: rgba(141, 141, 141, 0.3),
value: rgb(141 141 141 / 30%),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the rgb approach preferred moving forward?? Pretty cool format 👀

Copy link
Member Author

@tw15egan tw15egan Feb 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, I had originally modified it to that format, but I was getting compilation errors when running the style tests. Any ideas on how to get around that?

@kodiakhq kodiakhq bot merged commit f99361d into carbon-design-system:main Feb 15, 2022
@jnm2377 jnm2377 mentioned this pull request Feb 22, 2022
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants