Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[structured list] selection variant needs peristent background for selected state #5232

Closed
Tracked by #13510
laurenmrice opened this issue Jan 31, 2020 · 7 comments · Fixed by #13384
Closed
Tracked by #13510

Comments

@laurenmrice
Copy link
Member

laurenmrice commented Jan 31, 2020

For the selected state, the background needs to stay with the checkmark. The background color of the selected state should be $layer-selected.


Spec:
Artboard

@tw15egan tw15egan self-assigned this Feb 3, 2020
@tw15egan tw15egan added the package: react carbon-components-react label Feb 3, 2020
@tw15egan tw15egan removed their assignment Feb 4, 2020
@tw15egan
Copy link
Member

tw15egan commented Feb 4, 2020

Seems like this is a larger bug with the actual implementation of the React StructuredList, rather than a simple styling bug. The problem does not exist in vanilla.

Can be bundled in with any changes based on the outcome of discussion regarding larger Structured List updates

#5065

@asudoh
Copy link
Contributor

asudoh commented Feb 4, 2020

@tw15egan Just curious, is there any specific place in code where got an impression that this problem stems from how React StructuredList is implemented? Thanks!

@tw15egan
Copy link
Member

tw15egan commented Feb 4, 2020

Just a quick look at it, I'm seeing that it mainly just renders children, so the issue will be with getting the checked value back up to StructuredListRow. Can probably map over children and pass in a ref, but if there are plans to update this component then I'm not too sure how much time we wanted to spend on it right now.

@asudoh
Copy link
Contributor

asudoh commented Feb 6, 2020

Thanks @tw15egan for clarifying! I think we can listen to change event on <StructuredListRow> by letting the event bubble, but doing so causes an issue with programmatic control of the checked state. So agreed that it may involve a breaking change.

@tw15egan
Copy link
Member

@asudoh I've been messing around with this one this afternoon, but I'm running into problems with programmatic controls like you said. Wondering if you have ideas on a possible solution to this issue, as well as #1937

@sstrubberg
Copy link
Member

Need to update specs to v11.

@sstrubberg sstrubberg added package: @carbon/react @carbon/react and removed package: react carbon-components-react labels Nov 14, 2022
@laurenmrice
Copy link
Member Author

updated the spec!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants