Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AVT 3 - Carbon X Structured List does not announce checkbox or checkbox status using a screen reader #1937

Closed
snidersd opened this issue Feb 27, 2019 · 10 comments · Fixed by #8172
Assignees

Comments

@snidersd
Copy link

Environment

macOS Mojave version 10.14.2
Chrome version 72.0.3626.96 (Official Build) (64-bit)

Windows 7
Chrome version 72.0.3626.96 (Official Build) (64-bit)
JAWS

Description

AVT 3 - Structured List does not announce that there is a checkbox or the check box state.

  1. Navigate to the first row in the list by pressing the tab key.
  2. Press Ctrl-Option Right Arrow and navigate across the row.

Actual result: The checkbox is skipped and the status is not announced.
Expected result: VO should announce the checkbox and the state of checked or unchecked.

Note: Add the ARIA role="checkbox" and aria-checked="true"(or false when unchecked).

@dakahn
Copy link
Contributor

dakahn commented Mar 1, 2019

Great catch! Will need to do a little further research and see if this fails for VO and NVDA as well.

@dakahn dakahn added this to the v10.0-rc1 milestone Mar 14, 2019
@alisonjoseph alisonjoseph modified the milestones: v10.0-rc1, v10-update Mar 14, 2019
@stale
Copy link

stale bot commented May 1, 2019

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. Thanks for your contributions.

@stale stale bot added the wontfix label May 1, 2019
@snidersd
Copy link
Author

snidersd commented May 1, 2019

This issue should remain open until it is fixed and retested.

@stale stale bot removed the wontfix label May 1, 2019
@dakahn dakahn added the severity: 1 https://ibm.biz/carbon-severity label May 9, 2019
@stale
Copy link

stale bot commented Jun 8, 2019

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the status: inactive Will close if there's no further activity within a given time label Jun 8, 2019
@stale
Copy link

stale bot commented Jun 11, 2019

As there's been no activity since this issue was marked as stale, we are auto-closing it.

@stale stale bot closed this as completed Jun 11, 2019
@snidersd
Copy link
Author

Retested and this is still an issue in Structured List with Selection.
For React: Tab to selection and keyboard does not allow a selection or announce which one is selected.
For Vanilla: Tab to selection and hit Enter to make a selection, the check box displays but does not hold the setting or announce that it is checked.

The keyboard issues are present with and without of screenreader for both Vanilla and React.

@snidersd snidersd reopened this Jun 12, 2019
@dakahn dakahn added this to the Carbon WCAG Compliance milestone Nov 21, 2019
@emyarod
Copy link
Member

emyarod commented Nov 22, 2019

I believe this is blocked similar to #1882 esp if the markup is to be updated. substituting display: none with the visually-hidden classes introduces new DAP errors which don't seem to be false positives

@joshblack
Copy link
Contributor

Following up on this now, our first step was to update the markup to contain the relevant ARIA roles for tabular data so that the control could be navigable.

Marking as blocked as we are unsure how to proceed with implementing selection. In particular, how do we communicate that a row has been selected to a screen reader.

@dakahn
Copy link
Contributor

dakahn commented Jan 16, 2020

Tested on Windows 10 latest in Firefox and cannot make a selection with the keyboard :hurtrealbad:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
9 participants