Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataTable]: Keyboard navigation broken when using batch action version #5049

Closed
janhassel opened this issue Jan 15, 2020 · 0 comments · Fixed by #5081
Closed

[DataTable]: Keyboard navigation broken when using batch action version #5049

janhassel opened this issue Jan 15, 2020 · 0 comments · Fixed by #5081
Labels
component: data-table severity: 1 https://ibm.biz/carbon-severity type: a11y ♿ type: bug 🐛

Comments

@janhassel
Copy link
Member

Environment

Operating system
macOS 10.14.6

Browser
Chrome 79
Firefox 72
Safari 12.1.2

Detailed description

What version of the Carbon Design System are you using?
[email protected]
[email protected]

When trying to use the batch action version of the DataTable, pressing ⇥ Tab for the first time results in the toolbar being hidden (Chrome and Firefox; Safari highlights search). When pressing another time, the focus is still not visible (Chrome and Firefox; Safari loses focus completely and jumps to the next item on the page after the DataTable).
I need to press ⇥ Tab three more times before Chrome and Firefox highlight the search.

Steps to reproduce the issue

  1. Open http://react.carbondesignsystem.com/?path=/story/datatable--with-batch-actions in Chrome or Firefox
  2. Click once on the title "DataTable" to ensure keyboard focus is generally in the table
  3. Press ⇥ Tab repeatedly
asudoh added a commit to asudoh/carbon-components that referenced this issue Jan 17, 2020
@asudoh
fix(TableBatchActions): ensure hidden action bar un-focusable
117f827 
This change prevents hidden table batch action bar contents from being
focused.

Fixes carbon-design-system#5049.
@asudoh asudoh mentioned this issue Jan 17, 2020
Merged
asudoh added a commit that referenced this issue Jan 21, 2020
@asudoh
fix(TableBatchActions): ensure hidden action bar un-focusable (#5081)
8799d8e 
This change prevents hidden table batch action bar contents from being
focused.

Fixes #5049.
joshblack pushed a commit to joshblack/carbon that referenced this issue Jan 23, 2020
@asudoh @joshblack
fix(TableBatchActions): ensure hidden action bar un-focusable (carbon…
b994c9a 
…-design-system#5081)

This change prevents hidden table batch action bar contents from being
focused.

Fixes carbon-design-system#5049.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: data-table severity: 1 https://ibm.biz/carbon-severity type: a11y ♿ type: bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(TableBatchActions): ensure hidden action bar un-focusable asudoh/carbon-components
2 participants
@emyarod @janhassel