Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Notification] Low contrast style bugs #4282

Closed
1 of 2 tasks
aagonzales opened this issue Oct 9, 2019 · 5 comments
Closed
1 of 2 tasks

[Notification] Low contrast style bugs #4282

aagonzales opened this issue Oct 9, 2019 · 5 comments

Comments

@aagonzales
Copy link
Member

aagonzales commented Oct 9, 2019

There are some style bugs with the low contrast variation of notification

  • Inline notifications in White and Gray 10 themes need to add color border and remove the drop-shadow. See spec section below

    • As-is:
    • image
  • Gray 90 and Gray 100 low contrast notifications are completely wrong and should look like the specs in next section

    • As is:
    • image

Specs

Sketch file: https://ibm.box.com/s/wlqdd8ayfcvf4omy7616ldzs2elei9bv

To-be:

Gray 100 Gray 90
White Gray 10
@jnm2377 jnm2377 added priority: high severity: 2 https://ibm.biz/carbon-severity and removed type: a11y ♿ labels Oct 10, 2019
asudoh added a commit to asudoh/carbon-components that referenced this issue Oct 11, 2019
This change also makes inline notification's text color non-themeable
for now, given the background color is non-themeable and making it
themeable requires themeable component-specific token (or new global
theme tokens).

This stop-gap approach may be enough for short team because IIRC
low-contrast notifications is there for a backword-compatibility
reason.

Refs carbon-design-system#4282.
@aledavila
Copy link
Contributor

was this solve in #4299? @aagonzales

@aagonzales
Copy link
Member Author

aagonzales commented Feb 18, 2020

It is partially resolved. The low contrast notification in the Gray 90 and Gray 100 theme are not to spec but is blocked by component level theming (or something to that effect, there's a dev blocker). They are at least now legible and usable.

As-is:
image

To-be:
image

@emyarod
Copy link
Member

emyarod commented Mar 8, 2021

this is still blocked by compnent level theming right? for a workaround would we want to add a component level token or should we continue holding off until component level theming has been implemented?

@aagonzales
Copy link
Member Author

@emyarod Actually it looks like the low contrast notifications in the dark theme are showing correctly now in the storybook. I'm not sure when it was resolved.

image

@emyarod
Copy link
Member

emyarod commented Mar 8, 2021

resolved in #7808

@emyarod emyarod closed this as completed Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants