Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AVT 2 React Fixed SideNav, & SideNav w/Icon UI Shell hides text when zoom is 150+ #3591

Closed
snidersd opened this issue Jul 30, 2019 · 0 comments · Fixed by #4886
Closed

AVT 2 React Fixed SideNav, & SideNav w/Icon UI Shell hides text when zoom is 150+ #3591

snidersd opened this issue Jul 30, 2019 · 0 comments · Fixed by #4886
Labels
component: ui-shell severity: 1 https://ibm.biz/carbon-severity type: a11y ♿

Comments

@snidersd
Copy link

Environment

macOS Mojave version 10.14.5
Chrome Version 75.0.3770.100 (Official Build) (64-bit)
Carbon v10 - React

Detailed Description

Open either the React Fixed SideNav, & SideNav w/Icon UI Shell and zoom to 150% or more. The text in the main content (right panel) is no longer visible on the left-hand side. (see screenshot):
Screen Shot 2019-07-30 at 1 47 25 PM

See WCAG 2.0 - Resize text: Understanding SC 1.4.4
@aledavila aledavila added this to the UI Shell - A11y Project Team milestone Sep 30, 2019
@dakahn dakahn added priority: high severity: 1 https://ibm.biz/carbon-severity labels Sep 30, 2019
@dakahn dakahn modified the milestones: UI Shell - A11y Project Team, Carbon WCAG Compliance Nov 21, 2019
@dakahn dakahn mentioned this issue Nov 22, 2019
Closed
@mattrosno mattrosno removed this from the ♿Carbon WCAG Compliance♿ milestone Dec 13, 2019
asudoh added a commit to asudoh/carbon-components that referenced this issue Dec 16, 2019
@asudoh
fix(devenv): use content margin style for expanded side nav
1136712 
This change ensures that the fixed side nav stories make use of
`margin-left` style for `.bx--content` with `.bx--side-nav--expanded`
instead of using responsive left margin `v10` grid defines, so that the
main content won't be hidden underneath the fixed side nav when fixed
it's expanded.

Fixes carbon-design-system#3591.
@asudoh asudoh mentioned this issue Dec 16, 2019
Merged
asudoh added a commit that referenced this issue Dec 17, 2019
@asudoh
fix(devenv): use content margin style for expanded side nav (#4886)
061dac5 
This change ensures that the fixed side nav stories make use of
`margin-left` style for `.bx--content` with `.bx--side-nav--expanded`
instead of using responsive left margin `v10` grid defines, so that the
main content won't be hidden underneath the fixed side nav when fixed
it's expanded.

Fixes #3591.
joshblack pushed a commit to joshblack/carbon that referenced this issue Jan 6, 2020
@asudoh @joshblack
fix(devenv): use content margin style for expanded side nav (carbon-d…
4bd9776 
…esign-system#4886)

This change ensures that the fixed side nav stories make use of
`margin-left` style for `.bx--content` with `.bx--side-nav--expanded`
instead of using responsive left margin `v10` grid defines, so that the
main content won't be hidden underneath the fixed side nav when fixed
it's expanded.

Fixes carbon-design-system#3591.
@hixio-mh hixio-mh mentioned this issue Jan 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: ui-shell severity: 1 https://ibm.biz/carbon-severity type: a11y ♿
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(devenv): use content margin style for expanded side nav asudoh/carbon-components
5 participants
@mattrosno @joshblack @aledavila @snidersd @dakahn