Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI Shell] [Rails] - Submenu should collapse when rail is closed #3527

Closed
1 of 2 tasks
jnm2377 opened this issue Jul 24, 2019 · 0 comments · Fixed by #3626
Closed
1 of 2 tasks

[UI Shell] [Rails] - Submenu should collapse when rail is closed #3527

jnm2377 opened this issue Jul 24, 2019 · 0 comments · Fixed by #3626
Labels
package: react carbon-components-react severity: 1 https://ibm.biz/carbon-severity type: bug 🐛

Comments

@jnm2377
Copy link
Contributor

jnm2377 commented Jul 24, 2019 •
edited
Loading

What package(s) are you using?

  • carbon-components
  • carbon-components-react

Detailed description

Describe in detail the issue you're having.

If rails is collapsed but the submenu is still expanded, you see additional whitespace which is essentially the submenu items. Additionally, if one of these submenu items is focused or selected, you see the active state but it looks off since you can't see the submenu items in collapsed rails.

rails-bug

Is this issue related to a specific component?

UI Shell rails variation

What did you expect to happen? What happened instead? What would you like to
see changed?

The submenu should also collapse so that there's no whitespace from the submenu items.

rails-bug2

Steps to reproduce the issue

  1. Step one: Expand rails
  2. Step two: Open a submenu and select a submenu item
  3. Step three: Collapse rails
  4. Step four: Notice submenu bug
@jnm2377 jnm2377 added project: ui shell type: bug 🐛 severity: 1 https://ibm.biz/carbon-severity package: react carbon-components-react labels Jul 24, 2019
@vikkipaterson vikkipaterson mentioned this issue Jul 31, 2019
Closed
matthew-chirgwin pushed a commit to matthew-chirgwin/carbon that referenced this issue Aug 1, 2019
fix(sidenav): sidenavmenu stays open when in rail
b0866e0 
Fixes carbon-design-system#3527
@matthew-chirgwin matthew-chirgwin mentioned this issue Aug 1, 2019
Merged
jnm2377 pushed a commit that referenced this issue Aug 22, 2019
@matthew-chirgwin @jnm2377
fix(sidenav): sidenavmenu stays open when in rail (#3626)
92076fd 
* fix(sidenav): sidenavmenu stays open when in rail

Fixes #3527

* fix(sidenav): sidenavmenu stays open when in rail

Fixes issue found with existing behaviour

* fix(sidenav): sidenavmenu stays open when in rail

Update storybook

* fix(sidenav): sidenavmenu stays open when in rail

Fix expansion issue

* fix(sidenav): sidenavmenu stays open when in rail

Removed eye catcher comment from last commit

* fix(sidenav): make sidenav open/close via keyboard

Fixes #3529

* fix(sidenav): make sidenav open/close via keyboard

Address review comment

* fix(sidenav): sidenavmenu stays open when in rail

add/fix isActive check in menu
@asudoh asudoh mentioned this issue Nov 19, 2019
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package: react carbon-components-react severity: 1 https://ibm.biz/carbon-severity type: bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(sidenav): sidenavmenu stays open when in rail matthew-chirgwin/carbon
1 participant
@jnm2377