-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Inline loading] Update checkmark icon and loader size #3040
Comments
Changes to match file uploader (Ref PR: #3016 ) |
We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions. |
not stale |
We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions. |
not stale |
We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions. |
not stale |
@laurenmrice A question; The spinner seems to have approximately 2.56 pixels for its stroke and 6.4 pixels for its radius (based on the center of the stroke). Any guidance wrt how these should change? I'm guessing that we are shrinking (only) the radius, but not fully certain. Any info would be nice. Thanks! |
Hey @asudoh The current spinner 16px spinner takes up the full 16px x 16px box. Our 16px icons usually have some padding around the icon so that the actual icon is a little smaller than 16px but sits within a 16px bounding box. We want to change the current spinner to have this padding like the other icons. The stroke should stay the same, but it should just get smaller to accommodate the padding. |
Thanks @laurenmrice for clarifying! |
Checkmark icon
Current:
New:
-Replace current check with
16/checkmark--filled
. Fill:interactive-01
and Check:icon-03
-8px between icon and text
The text was updated successfully, but these errors were encountered: