Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Inline loading] Update checkmark icon and loader size #3040

Closed
laurenmrice opened this issue Jun 12, 2019 · 11 comments · Fixed by #4382
Closed

[Inline loading] Update checkmark icon and loader size #3040

laurenmrice opened this issue Jun 12, 2019 · 11 comments · Fixed by #4382

Comments

@laurenmrice
Copy link
Member

laurenmrice commented Jun 12, 2019

Checkmark icon

Current:
Screen Shot 2019-06-12 at 3.02.37 PM.png

New:
-Replace current check with 16/checkmark--filled. Fill: interactive-01 and Check: icon-03
-8px between icon and text
Screen Shot 2019-06-12 at 3.02.42 PM.png

@laurenmrice
Copy link
Member Author

laurenmrice commented Jun 12, 2019

Loader

Current:
Screen Shot 2019-06-12 at 3 07 31 PM

New:
-16x16px container with a 14x14px loader.
-8px between loader and text
Screen Shot 2019-06-12 at 3 07 41 PM

@laurenmrice
Copy link
Member Author

Changes to match file uploader (Ref PR: #3016 )

@stale
Copy link

stale bot commented Jul 12, 2019

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the status: inactive Will close if there's no further activity within a given time label Jul 12, 2019
@laurenmrice
Copy link
Member Author

not stale

@stale stale bot removed the status: inactive Will close if there's no further activity within a given time label Jul 15, 2019
@stale
Copy link

stale bot commented Aug 14, 2019

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the status: inactive Will close if there's no further activity within a given time label Aug 14, 2019
@laurenmrice
Copy link
Member Author

not stale

@stale stale bot removed the status: inactive Will close if there's no further activity within a given time label Aug 14, 2019
@stale
Copy link

stale bot commented Sep 13, 2019

We've marked this issue as stale because there hasn't been any activity for a couple of weeks. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions.

@stale stale bot added the status: inactive Will close if there's no further activity within a given time label Sep 13, 2019
@laurenmrice
Copy link
Member Author

not stale

@stale stale bot removed the status: inactive Will close if there's no further activity within a given time label Sep 16, 2019
@asudoh
Copy link
Contributor

asudoh commented Oct 8, 2019

@laurenmrice A question; The spinner seems to have approximately 2.56 pixels for its stroke and 6.4 pixels for its radius (based on the center of the stroke). Any guidance wrt how these should change? I'm guessing that we are shrinking (only) the radius, but not fully certain. Any info would be nice. Thanks!

@laurenmrice
Copy link
Member Author

laurenmrice commented Oct 17, 2019

Hey @asudoh The current spinner 16px spinner takes up the full 16px x 16px box. Our 16px icons usually have some padding around the icon so that the actual icon is a little smaller than 16px but sits within a 16px bounding box. We want to change the current spinner to have this padding like the other icons. The stroke should stay the same, but it should just get smaller to accommodate the padding.

Ex: We want the one on the right with padding
Screen Shot 2019-10-17 at 12 47 57 PM

asudoh added a commit to asudoh/carbon-components that referenced this issue Oct 18, 2019
@asudoh
Copy link
Contributor

asudoh commented Oct 18, 2019

Thanks @laurenmrice for clarifying!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants