Skip to content

Add TypeScript types to ComposedModal, ModalHeader, ModalBody, ModalFooter #13534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #12513
tay1orjones opened this issue Apr 17, 2023 · 1 comment · Fixed by #13628
Closed
Tracked by #12513

Add TypeScript types to ComposedModal, ModalHeader, ModalBody, ModalFooter #13534

tay1orjones opened this issue Apr 17, 2023 · 1 comment · Fixed by #13628
Labels
area: typescript hacktoberfest See https://hacktoberfest.com/ needs: community contribution Due to roadmap and resource availability, we are looking for outside contributions on this issue. role: dev 🤖 status: help wanted 👐

Comments

@tay1orjones
Copy link
Member

No description provided.

@tay1orjones tay1orjones mentioned this issue Apr 17, 2023
Closed
@tay1orjones tay1orjones added status: help wanted 👐 role: dev 🤖 hacktoberfest See https://hacktoberfest.com/ area: typescript needs: community contribution Due to roadmap and resource availability, we are looking for outside contributions on this issue. labels Apr 17, 2023
@kubijo
Copy link
Contributor

kubijo commented Apr 19, 2023

I'm taking this

kubijo added a commit to kubijo/carbon that referenced this issue Apr 19, 2023
@kubijo
feat(ComposedModal): rename to tsx carbon-design-system#13534
a17b48b
kubijo added a commit to kubijo/carbon that referenced this issue Apr 19, 2023
@kubijo
feat(ComposedModal): add types carbon-design-system#13534
7f0349c
@kubijo kubijo mentioned this issue Apr 19, 2023
Merged
kubijo added a commit to kubijo/carbon that referenced this issue Apr 19, 2023
@kubijo
feat(ComposedModal): add types carbon-design-system#13534
53a62a0
kubijo added a commit to kubijo/carbon that referenced this issue Apr 20, 2023
@kubijo
feat(ComposedModal): rename to tsx carbon-design-system#13534
dcc2806
kubijo added a commit to kubijo/carbon that referenced this issue Apr 20, 2023
@kubijo
feat(ComposedModal): add types carbon-design-system#13534
12c4170
kubijo added a commit to kubijo/carbon that referenced this issue Apr 20, 2023
@kubijo
feat(ComposedModal): add types carbon-design-system#13534
ac03a43
kubijo added a commit to kubijo/carbon that referenced this issue Apr 21, 2023
@kubijo
feat(ComposedModal): rename to tsx carbon-design-system#13534
d8932b6
kubijo added a commit to kubijo/carbon that referenced this issue Apr 21, 2023
@kubijo
feat(ComposedModal): add types carbon-design-system#13534
40f739d
kubijo added a commit to kubijo/carbon that referenced this issue Apr 22, 2023
@kubijo
feat(ComposedModal): add types carbon-design-system#13534
6c5cd53
kubijo added a commit to kubijo/carbon that referenced this issue Apr 27, 2023
@kubijo
feat(ComposedModal): rename to tsx carbon-design-system#13534
3b87df6
kubijo added a commit to kubijo/carbon that referenced this issue Apr 27, 2023
@kubijo
feat(ComposedModal): add types carbon-design-system#13534
f95a514
kubijo added a commit to kubijo/carbon that referenced this issue May 9, 2023
@kubijo
feat(ComposedModal): rename to tsx carbon-design-system#13534
f513cd6
kubijo added a commit to kubijo/carbon that referenced this issue May 9, 2023
@kubijo
feat(ComposedModal): add types carbon-design-system#13534
5485271
kubijo added a commit to kubijo/carbon that referenced this issue Jun 7, 2023
@kubijo
feat(ComposedModal): rename to tsx carbon-design-system#13534
5570a20
kubijo added a commit to kubijo/carbon that referenced this issue Jun 7, 2023
@kubijo
feat(ComposedModal): add types carbon-design-system#13534
4453cd4
kubijo added a commit to kubijo/carbon that referenced this issue Jun 7, 2023
@kubijo
feat(ComposedModal): rename to tsx carbon-design-system#13534
6707973
kubijo added a commit to kubijo/carbon that referenced this issue Jun 7, 2023
@kubijo
feat(ComposedModal): add types carbon-design-system#13534
eb28d81
kubijo added a commit to kubijo/carbon that referenced this issue Jun 9, 2023
@kubijo
feat(ComposedModal): rename to tsx carbon-design-system#13534
3c552d3
kubijo added a commit to kubijo/carbon that referenced this issue Jun 9, 2023
@kubijo
feat(ComposedModal): add types carbon-design-system#13534
66d45f1
@kodiakhq kodiakhq bot closed this as completed in #13628 Jun 12, 2023
kodiakhq bot added a commit that referenced this issue Jun 12, 2023
@kubijo @kodiakhq @francinelucca
Add TypeScript types to ComposedModal, ModalHeader, ModalBody, Modal…
ceda14d 
…Footer #13534  (#13628)

* feat(ComposedModal): rename to tsx #13534

* feat(ComposedModal): add types #13534

* chore(ComposedModal): fix regressive tests + related cleanup

---------

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Co-authored-by: Francine Lucca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: typescript hacktoberfest See https://hacktoberfest.com/ needs: community contribution Due to roadmap and resource availability, we are looking for outside contributions on this issue. role: dev 🤖 status: help wanted 👐
Projects
No open projects
Initial TypeScript Support
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add TypeScript types to ComposedModal, ModalHeader, ModalBody, ModalFooter #13534 kubijo/carbon
2 participants
@tay1orjones @kubijo