Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TypeScript types to TableSelectAll #12530

Closed
Tracked by #12513
tay1orjones opened this issue Nov 7, 2022 · 1 comment · Fixed by #12989
Closed
Tracked by #12513

Add TypeScript types to TableSelectAll #12530

tay1orjones opened this issue Nov 7, 2022 · 1 comment · Fixed by #12989
Labels
area: typescript hacktoberfest See https://hacktoberfest.com/ needs: community contribution Due to roadmap and resource availability, we are looking for outside contributions on this issue. role: dev 🤖 status: help wanted 👐

Comments

@tay1orjones
Copy link
Member

No description provided.

@tay1orjones tay1orjones mentioned this issue Nov 7, 2022
Closed
@tay1orjones tay1orjones added role: dev 🤖 area: typescript needs: community contribution Due to roadmap and resource availability, we are looking for outside contributions on this issue. status: help wanted 👐 hacktoberfest See https://hacktoberfest.com/ labels Nov 7, 2022
@jpsorensen
Copy link
Contributor

Working on this

jpsorensen added a commit to jpsorensen/carbon that referenced this issue Jan 19, 2023
@jpsorensen
refactor(TableSelectAll): add typescript annotations
55e2117 
Convert existing propType definitions to Typescript annotations on the
TableSelectAll component. This is part of a broader effort to add
Typescript annotations to components, tracked in carbon-design-system#12513. Closes carbon-design-system#12530.

Type annotation changes only; no breaking feature changes.
@jpsorensen jpsorensen mentioned this issue Jan 19, 2023
Merged
@kodiakhq kodiakhq bot closed this as completed in #12989 Jan 28, 2023
kodiakhq bot pushed a commit that referenced this issue Jan 28, 2023
@jpsorensen
Add Typescript annotations to TableSelectAll (#12989)
3263e61 
* refactor(TableSelectAll): add typescript annotations

Convert existing propType definitions to Typescript annotations on the
TableSelectAll component. This is part of a broader effort to add
Typescript annotations to components, tracked in #12513. Closes #12530.

Type annotation changes only; no breaking feature changes.

* fix(typescript): fix InlineCheckbox property types

Because InlineCheckbox does not have type definitions, it gets its input
property type definitions from React.forwardRef, and so does not allow extra
properties. This results in errors like:
Property 'ariaLabel' does not exist on type 'IntrinsicAttributes &
RefAttributes<any>'.
when we adopt TS in files that use InlineCheckbox. Since InlineCheckbox is
internal-only, policy is not to add types but to mark as type: any.

* fix(typescript): fix DataTable exports tests

DataTable has a set of tests which check that all files in the directory (with
some specific exceptions) export a default component with the same name as the
file. This test got the expected name of the component by stripping ".js" from
the filename. This won't work for Typescript files, which have a different
extension. Stripped off the extension regardless of what it was instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: typescript hacktoberfest See https://hacktoberfest.com/ needs: community contribution Due to roadmap and resource availability, we are looking for outside contributions on this issue. role: dev 🤖 status: help wanted 👐
Projects
No open projects
Initial TypeScript Support
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Typescript annotations to TableSelectAll jpsorensen/carbon
2 participants
@tay1orjones @jpsorensen