fix(OverflowMenu): prevent page scroll on menu navigation and selecti…

…on (#4336)
carbon-design-system · Oct 22, 2019 · 700f21d · 700f21d
1 parent 427a7dd
commit 700f21d
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/packages/react/src/components/OverflowMenu/OverflowMenu.js b/packages/react/src/components/OverflowMenu/OverflowMenu.js
@@ -319,6 +319,10 @@ class OverflowMenu extends Component {
   };
 
   handleKeyPress = evt => {
+    if (!keyCodeMatches(evt, [keys.Enter, keys.Space])) {
+      evt.preventDefault();
+    }
+
     // only respond to key events when the menu is closed, so that menu items still respond to key events
     if (!this.state.open) {
       if (keyCodeMatches(evt, [keys.Enter, keys.Space])) {
@@ -331,7 +335,6 @@ class OverflowMenu extends Component {
       this.closeMenu();
       // Stop the esc keypress from bubbling out and closing something it shouldn't
       evt.stopPropagation();
-      evt.preventDefault();
     }
   };