Merge branch 'main' into deprecate-controlled-password-input

carbon-design-system · May 4, 2021 · 280c47a · 280c47a
2 parents 1cdd2e4 + 001b6d5
commit 280c47a
Show file tree

Hide file tree

Showing 44 changed files with 247 additions and 228 deletions.
diff --git a/.yarn/cache/@npmcli-ci-detect-npm-1.3.0-ad562ca529-3ba5e974c7.zip b/.yarn/cache/@npmcli-ci-detect-npm-1.3.0-ad562ca529-3ba5e974c7.zip
diff --git a/.yarn/cache/@npmcli-installed-package-contents-npm-1.0.5-caab6b70d8-a26ca961d9.zip b/.yarn/cache/@npmcli-installed-package-contents-npm-1.0.5-caab6b70d8-a26ca961d9.zip
diff --git a/.yarn/cache/@npmcli-installed-package-contents-npm-1.0.7-b15a13ab4f-a4a29b99d4.zip b/.yarn/cache/@npmcli-installed-package-contents-npm-1.0.7-b15a13ab4f-a4a29b99d4.zip
diff --git a/.yarn/cache/@npmcli-node-gyp-npm-1.0.1-8bc99566e5-5b3e454316.zip b/.yarn/cache/@npmcli-node-gyp-npm-1.0.1-8bc99566e5-5b3e454316.zip
diff --git a/.yarn/cache/@npmcli-node-gyp-npm-1.0.2-03ebda3e29-ee4b070686.zip b/.yarn/cache/@npmcli-node-gyp-npm-1.0.2-03ebda3e29-ee4b070686.zip
diff --git a/...cript-npm-1.8.1-c2f0f8eb8a-4c5a381a06.zip → ...cript-npm-1.8.5-63c0b50478-734f7d4bec.zip b/...cript-npm-1.8.1-c2f0f8eb8a-4c5a381a06.zip → ...cript-npm-1.8.5-63c0b50478-734f7d4bec.zip
diff --git a/.yarn/cache/@rollup-plugin-commonjs-npm-17.0.0-3f87c4fa6b-b569a9923a.zip b/.yarn/cache/@rollup-plugin-commonjs-npm-17.0.0-3f87c4fa6b-b569a9923a.zip
diff --git a/.yarn/cache/@rollup-plugin-replace-npm-2.3.4-2b255f0126-5ddd9d207c.zip b/.yarn/cache/@rollup-plugin-replace-npm-2.3.4-2b255f0126-5ddd9d207c.zip
diff --git a/.yarn/cache/@rollup-plugin-replace-npm-2.4.2-86e64ab79f-b2f1618ee5.zip b/.yarn/cache/@rollup-plugin-replace-npm-2.4.2-86e64ab79f-b2f1618ee5.zip
diff --git a/.yarn/cache/boxen-npm-5.0.1-e69c4085ea-a5fd6e48ec.zip b/.yarn/cache/boxen-npm-5.0.1-e69c4085ea-a5fd6e48ec.zip
diff --git a/.yarn/cache/camelcase-npm-6.0.0-9f3e9c28c5-28f42db097.zip b/.yarn/cache/camelcase-npm-6.0.0-9f3e9c28c5-28f42db097.zip
diff --git a/.yarn/cache/camelcase-npm-6.2.0-69f8c130ac-8335cfd0ec.zip b/.yarn/cache/camelcase-npm-6.2.0-69f8c130ac-8335cfd0ec.zip
diff --git a/.yarn/cache/cli-boxes-npm-2.2.0-d10e4d5632-720560248b.zip b/.yarn/cache/cli-boxes-npm-2.2.0-d10e4d5632-720560248b.zip
diff --git a/.yarn/cache/cli-boxes-npm-2.2.1-7125a5ba44-be79f8ec23.zip b/.yarn/cache/cli-boxes-npm-2.2.1-7125a5ba44-be79f8ec23.zip
diff --git a/.yarn/cache/err-code-npm-2.0.3-082e0ff9a7-8b7b1be20d.zip b/.yarn/cache/err-code-npm-2.0.3-082e0ff9a7-8b7b1be20d.zip
diff --git a/.yarn/cache/npm-registry-fetch-npm-10.1.1-163563ba29-d4ee70bc72.zip b/.yarn/cache/npm-registry-fetch-npm-10.1.1-163563ba29-d4ee70bc72.zip
diff --git a/.yarn/cache/npm-registry-fetch-npm-9.0.0-3a14ee1925-b5376b72ef.zip b/.yarn/cache/npm-registry-fetch-npm-9.0.0-3a14ee1925-b5376b72ef.zip
diff --git a/.yarn/cache/pacote-npm-11.2.3-1e05fea00d-60650e837c.zip b/.yarn/cache/pacote-npm-11.2.3-1e05fea00d-60650e837c.zip
diff --git a/.yarn/cache/pacote-npm-11.3.3-3db6456620-fb64264770.zip b/.yarn/cache/pacote-npm-11.3.3-3db6456620-fb64264770.zip
diff --git a/.yarn/cache/promise-retry-npm-2.0.1-871f0b01b7-f96a3f6d90.zip b/.yarn/cache/promise-retry-npm-2.0.1-871f0b01b7-f96a3f6d90.zip
diff --git a/.yarn/cache/puka-npm-1.0.1-e8350b8346-bccd754bf3.zip b/.yarn/cache/puka-npm-1.0.1-e8350b8346-bccd754bf3.zip
diff --git a/.yarn/cache/read-package-json-fast-npm-1.2.1-31adc168d6-f40fb338a8.zip b/.yarn/cache/read-package-json-fast-npm-1.2.1-31adc168d6-f40fb338a8.zip
diff --git a/.yarn/cache/read-package-json-fast-npm-2.0.2-886bc676d1-81a45b0bdb.zip b/.yarn/cache/read-package-json-fast-npm-2.0.2-886bc676d1-81a45b0bdb.zip
diff --git a/.yarn/cache/rollup-npm-2.44.0-933a5cc29a-7c791a1f94.zip b/.yarn/cache/rollup-npm-2.44.0-933a5cc29a-7c791a1f94.zip
diff --git a/.yarn/cache/rollup-npm-2.46.0-a6e5e68d7e-90eb8d351d.zip b/.yarn/cache/rollup-npm-2.46.0-a6e5e68d7e-90eb8d351d.zip
diff --git a/.yarn/cache/rollup-plugin-filesize-npm-9.1.0-1236c4b274-de5cc89678.zip b/.yarn/cache/rollup-plugin-filesize-npm-9.1.0-1236c4b274-de5cc89678.zip
diff --git a/.yarn/cache/rollup-plugin-filesize-npm-9.1.1-d030e25992-7318d2c5bf.zip b/.yarn/cache/rollup-plugin-filesize-npm-9.1.1-d030e25992-7318d2c5bf.zip
diff --git a/.yarn/cache/rollup-plugin-sizes-npm-1.0.3-be43c0577a-d470721710.zip b/.yarn/cache/rollup-plugin-sizes-npm-1.0.3-be43c0577a-d470721710.zip
diff --git a/.yarn/cache/rollup-plugin-sizes-npm-1.0.4-f85410f9be-8672d72a33.zip b/.yarn/cache/rollup-plugin-sizes-npm-1.0.4-f85410f9be-8672d72a33.zip
diff --git a/.yarn/cache/ssri-npm-8.0.0-276fb838a8-50085886f4.zip b/.yarn/cache/ssri-npm-8.0.0-276fb838a8-50085886f4.zip
diff --git a/.yarn/cache/ssri-npm-8.0.1-a369e72ce2-bc447f5af8.zip b/.yarn/cache/ssri-npm-8.0.1-a369e72ce2-bc447f5af8.zip
diff --git a/.yarn/cache/type-fest-npm-0.20.2-b36432617f-4fb3272df2.zip b/.yarn/cache/type-fest-npm-0.20.2-b36432617f-4fb3272df2.zip
diff --git a/packages/carbon-react/package.json b/packages/carbon-react/package.json
@@ -61,7 +61,7 @@
     "react": "^16.8.6",
     "react-dom": "^16.8.6",
     "rimraf": "^3.0.2",
-    "rollup": "^2.44.0",
+    "rollup": "^2.46.0",
     "rollup-plugin-strip-banner": "^2.0.0"
   },
   "sideEffects": [

diff --git a/packages/cli/package.json b/packages/cli/package.json
@@ -28,9 +28,9 @@
     "@octokit/plugin-retry": "^3.0.7",
     "@octokit/plugin-throttling": "^2.6.0",
     "@octokit/rest": "^16.28.1",
-    "@rollup/plugin-babel": "^5.2.2",
-    "@rollup/plugin-commonjs": "^17.0.0",
-    "@rollup/plugin-node-resolve": "^11.1.0",
+    "@rollup/plugin-babel": "^5.3.0",
+    "@rollup/plugin-commonjs": "^18.0.0",
+    "@rollup/plugin-node-resolve": "^11.2.1",
     "chalk": "^2.4.2",
     "change-case": "^4.1.2",
     "child-process-promise": "^2.2.1",
@@ -47,7 +47,7 @@
     "progress-estimator": "^0.2.2",
     "remark": "^10.0.1",
     "replace-in-file": "^6.1.0",
-    "rollup": "^2.38.0",
+    "rollup": "^2.46.0",
     "sass": "^1.32.4",
     "sassdoc": "^2.7.3",
     "yargs": "^15.1.0"

diff --git a/packages/components/package.json b/packages/components/package.json
@@ -89,10 +89,10 @@
     "@carbon/icons-react": "^10.31.0",
     "@carbon/test-utils": "^10.15.0",
     "@frctl/fractal": "^1.1.0",
-    "@rollup/plugin-babel": "^5.2.2",
-    "@rollup/plugin-commonjs": "^17.0.0",
-    "@rollup/plugin-node-resolve": "^11.1.0",
-    "@rollup/plugin-replace": "^2.3.4",
+    "@rollup/plugin-babel": "^5.3.0",
+    "@rollup/plugin-commonjs": "^18.0.0",
+    "@rollup/plugin-node-resolve": "^11.2.1",
+    "@rollup/plugin-replace": "^2.4.2",
     "@rollup/plugin-virtual": "^2.0.3",
     "adaro": "1.0.4",
     "autoprefixer": "^9.7.4",
@@ -163,8 +163,8 @@
     "react-copy-to-clipboard": "^5.0.0",
     "react-dom": "^16.8.6",
     "react-ga": "^3.3.0",
-    "rollup": "^2.38.0",
-    "rollup-plugin-filesize": "^9.1.0",
+    "rollup": "^2.46.0",
+    "rollup-plugin-filesize": "^9.1.1",
     "rollup-plugin-terser": "^7.0.2",
     "sass": "^1.24.5",
     "sass-loader": "^8.0.2",

diff --git a/packages/components/src/components/modal/_modal.scss b/packages/components/src/components/modal/_modal.scss
@@ -277,14 +277,24 @@
     left: 0;
     width: 100%;
     height: rem(32px);
-    // Safari interprets `transparent` differently, so make color token value transparent instead:
-    background-image: linear-gradient(to bottom, rgba($layer, 0), $layer);
+    background-image: linear-gradient(to bottom, transparent, $layer);
     content: '';
     grid-column: 1/-1;
     grid-row: 2/-2;
     pointer-events: none;
   }
 
+  // Safari-only media query
+  // won't appear correctly with CSS custom properties
+  // see: code snippet and tabs overflow indicators
+  @media not all and (min-resolution: 0.001dpcm) {
+    @supports (-webkit-appearance: none) and (stroke-color: transparent) {
+      .#{$prefix}--modal-content--overflow-indicator {
+        background-image: linear-gradient(to bottom, rgba($layer, 0), $layer);
+      }
+    }
+  }
+
   .#{$prefix}--modal-content:focus
     ~ .#{$prefix}--modal-content--overflow-indicator {
     width: calc(100% - 4px);

diff --git a/packages/components/src/components/text-input/_text-input.scss b/packages/components/src/components/text-input/_text-input.scss
@@ -75,89 +75,91 @@
     position: relative;
     display: flex;
     width: 100%;
-    align-items: center;
+  }
 
-    .#{$prefix}--text-input__invalid-icon {
-      position: absolute;
-      // top/transform used to center invalid icon in IE11
-      top: 50%;
-      right: $carbon--spacing-05;
-      fill: $support-error;
-      transform: translateY(-50%);
-    }
+  .#{$prefix}--text-input__invalid-icon {
+    position: absolute;
+    // top/transform used to center invalid icon in IE11
+    top: 50%;
+    right: $carbon--spacing-05;
+    fill: $support-error;
+    transform: translateY(-50%);
+  }
 
-    .#{$prefix}--text-input__invalid-icon--warning {
-      fill: $support-warning;
+  .#{$prefix}--text-input__invalid-icon--warning {
+    fill: $support-warning;
+  }
 
-      path:first-of-type {
-        fill: $carbon__black-100;
-        opacity: 1;
-      }
-    }
+  .#{$prefix}--text-input__invalid-icon--warning path:first-of-type {
+    fill: $carbon__black-100;
+    opacity: 1;
+  }
 
-    // TODO: deprecate this style block
-    .#{$prefix}--text-input--password__visibility {
-      @include tooltip--trigger('icon', 'bottom');
-      @include tooltip--placement('icon', 'bottom', 'center');
-    }
+  // TODO: deprecate this style block
+  .#{$prefix}--text-input--password__visibility {
+    @include tooltip--trigger('icon', 'bottom');
+    @include tooltip--placement('icon', 'bottom', 'center');
+  }
 
-    .#{$prefix}--text-input--password__visibility,
-    // TODO: remove selector above
-     .#{$prefix}--btn.#{$prefix}--text-input--password__visibility__toggle.#{$prefix}--tooltip__trigger {
-      @include focus-outline('reset');
-
-      position: absolute;
-      right: 0;
-      display: flex;
-      width: rem(40px);
-      height: rem(40px);
-      min-height: auto;
-      align-items: center;
-      justify-content: center;
-      padding: 0;
-      border: 0;
-      background: none;
-      cursor: pointer;
-      transition: outline $duration--fast-01 motion(standard, productive);
-
-      svg {
-        fill: $icon-secondary;
-        transition: fill $duration--fast-01 motion(standard, productive);
-      }
-    }
+  .#{$prefix}--text-input--password__visibility,
+  // TODO: remove selector above
+  .#{$prefix}--btn.#{$prefix}--text-input--password__visibility__toggle.#{$prefix}--tooltip__trigger {
+    @include focus-outline('reset');
 
-    .#{$prefix}--btn.#{$prefix}--text-input--password__visibility__toggle.#{$prefix}--tooltip__trigger:focus {
-      @include focus-outline('outline');
-    }
+    position: absolute;
+    right: 0;
+    display: flex;
+    width: rem(40px);
+    height: rem(40px);
+    min-height: auto;
+    align-items: center;
+    justify-content: center;
+    padding: 0;
+    border: 0;
+    background: none;
+    cursor: pointer;
+    transition: outline $duration--fast-01 motion(standard, productive);
+  }
 
-    .#{$prefix}--btn.#{$prefix}--text-input--password__visibility__toggle.#{$prefix}--tooltip__trigger:hover
-      svg,
-    .#{$prefix}--btn.#{$prefix}--text-input--password__visibility__toggle.#{$prefix}--tooltip__trigger:focus
-      svg {
-      fill: $icon-primary;
+  .#{$prefix}--btn.#{$prefix}--text-input--password__visibility__toggle.#{$prefix}--tooltip__trigger
+    svg {
+    fill: $icon-secondary;
+    transition: fill $duration--fast-01 motion(standard, productive);
+
+    // Windows, Firefox HCM Fix
+    @media screen and (-ms-high-contrast: active),
+      screen and (prefers-contrast) {
+      // `ButtonText` is a CSS2 system color to help improve colors in HCM
+      fill: ButtonText;
     }
+  }
 
-    .#{$prefix}--text-input--invalid,
-    .#{$prefix}--text-input--warning {
-      padding-right: $carbon--spacing-08;
-    }
+  .#{$prefix}--text-input--password__visibility__toggle.#{$prefix}--tooltip__trigger:focus {
+    @include focus-outline('outline');
+  }
 
-    .#{$prefix}--text-input--invalid.#{$prefix}--password-input {
-      padding-right: rem(64px);
-    }
+  .#{$prefix}--btn.#{$prefix}--text-input--password__visibility__toggle.#{$prefix}--tooltip__trigger:hover
+    svg,
+  .#{$prefix}--btn.#{$prefix}--text-input--password__visibility__toggle.#{$prefix}--tooltip__trigger:focus
+    svg {
+    fill: $icon-primary;
+  }
 
-    .#{$prefix}--text-input--invalid
-      + .#{$prefix}--text-input--password__visibility,
-    // TODO: remove selector above
-    .#{$prefix}--text-input--invalid
-      + .#{$prefix}--text-input--password__visibility__toggle {
-      right: $carbon--spacing-05;
-    }
+  .#{$prefix}--text-input--invalid,
+  .#{$prefix}--text-input--warning {
+    padding-right: $carbon--spacing-08;
   }
 
-  .#{$prefix}--text-input__field-wrapper.#{$prefix}--password-input__field-wrapper
-    .#{$prefix}--text-input__invalid-icon {
-    right: $carbon--spacing-07;
+  .#{$prefix}--text-input--invalid.#{$prefix}--password-input {
+    padding-right: rem(64px);
+  }
+
+  .#{$prefix}--text-input--invalid +
+    .#{$prefix}--text-input--password__visibility,
+  // TODO: remove selector above
+  .#{$prefix}--text-input--invalid +
+    .#{$prefix}--text-input--password__visibility__toggle {
+    right: $carbon--spacing-05;
   }
 
   .#{$prefix}--password-input-wrapper .#{$prefix}--text-input__invalid-icon {
@@ -169,8 +171,7 @@
     svg,
   // TODO: remove selector above
   .#{$prefix}--text-input:disabled
-    + .#{$prefix}--text-input--password__visibility__toggle
-    svg {
+    + .#{$prefix}--text-input--password__visibility__toggle.#{$prefix}--tooltip__trigger svg {
     cursor: not-allowed;
     fill: $icon-disabled;
 

diff --git a/packages/components/tests/pure-modules-test.js b/packages/components/tests/pure-modules-test.js
@@ -101,6 +101,7 @@ describe('ES modules', () => {
         nodeResolve(),
         replace({
           'process.env.NODE_ENV': JSON.stringify('production'),
+          preventAssignment: true,
         }),
         terser.terser(),
       ],

diff --git a/packages/feature-flags/package.json b/packages/feature-flags/package.json
@@ -41,7 +41,7 @@
     "fs-extra": "^9.0.1",
     "js-yaml": "^3.14.0",
     "rimraf": "^3.0.2",
-    "rollup": "^2.38.0",
+    "rollup": "^2.46.0",
     "rollup-plugin-strip-banner": "^2.0.0"
   },
   "sideEffects": false

diff --git a/packages/icon-build-helpers/package.json b/packages/icon-build-helpers/package.json
@@ -30,8 +30,8 @@
     "@babel/types": "^7.14.0",
     "@carbon/cli-reporter": "^10.4.0",
     "@carbon/icon-helpers": "^10.16.0",
-    "@rollup/plugin-babel": "^5.2.2",
-    "@rollup/plugin-replace": "^2.3.4",
+    "@rollup/plugin-babel": "^5.3.0",
+    "@rollup/plugin-replace": "^2.4.2",
     "browserslist-config-carbon": "^10.6.1",
     "change-case": "^4.1.1",
     "core-js": "^3.6.5",
@@ -45,7 +45,7 @@
     "react": "^16.6.0",
     "react-dom": "^16.6.0",
     "rimraf": "^3.0.0",
-    "rollup": "^2.38.0",
+    "rollup": "^2.46.0",
     "rollup-plugin-strip-banner": "^2.0.0",
     "svg-parser": "^2.0.4",
     "svgo": "^1.1.1"

diff --git a/packages/icons-vue/package.json b/packages/icons-vue/package.json
@@ -36,7 +36,7 @@
     "fs-extra": "^8.1.0",
     "prettier": "^2.2.1",
     "rimraf": "^3.0.0",
-    "rollup": "^2.38.0",
+    "rollup": "^2.46.0",
     "vue": "^2.6.8"
   },
   "sideEffects": false

diff --git a/packages/react/package.json b/packages/react/package.json
@@ -75,10 +75,10 @@
     "@babel/preset-react": "^7.13.13",
     "@carbon/test-utils": "^10.15.0",
     "@percy/storybook": "^3.3.1",
-    "@rollup/plugin-babel": "^5.2.2",
-    "@rollup/plugin-commonjs": "^17.0.0",
-    "@rollup/plugin-node-resolve": "^11.1.0",
-    "@rollup/plugin-replace": "^2.3.4",
+    "@rollup/plugin-babel": "^5.3.0",
+    "@rollup/plugin-commonjs": "^18.0.0",
+    "@rollup/plugin-node-resolve": "^11.2.1",
+    "@rollup/plugin-replace": "^2.4.2",
     "@storybook/addon-storysource": "^5.3.19",
     "@storybook/addons": "^5.3.19",
     "@storybook/react": "^5.3.19",
@@ -110,8 +110,8 @@
     "react-test-renderer": "^16.8.6",
     "requestanimationframe": "^0.0.23",
     "rimraf": "^3.0.0",
-    "rollup": "^2.38.0",
-    "rollup-plugin-sizes": "^1.0.3",
+    "rollup": "^2.46.0",
+    "rollup-plugin-sizes": "^1.0.4",
     "rollup-plugin-strip-banner": "^2.0.0",
     "rollup-plugin-terser": "^7.0.2",
     "rtlcss": "^2.4.0",

diff --git a/packages/react/rollup.config.js b/packages/react/rollup.config.js
@@ -104,6 +104,7 @@ module.exports = [
     plugins: [
       ...baseConfig.plugins,
       replace({
+        preventAssignment: true,
         'process.env.NODE_ENV': JSON.stringify('development'),
       }),
     ],
@@ -120,6 +121,7 @@ module.exports = [
     plugins: [
       ...baseConfig.plugins,
       replace({
+        preventAssignment: true,
         'process.env.NODE_ENV': JSON.stringify('production'),
       }),
       terser(),