-
Notifications
You must be signed in to change notification settings - Fork 762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs (dropdown): Images on style tab for select all functionality #4053
base: main
Are you sure you want to change the base?
Docs (dropdown): Images on style tab for select all functionality #4053
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
DCO Assistant Lite bot: Thanks for your submission! We ask that you all sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by adding a comment below using this text: I have read the DCO document and I hereby sign the DCO. 1 out of 2 committers have signed the DCO. |
When a dev have time, could you try to help with getting the vercel preview to show the image changes? For some reason the images are not updating in the preview. @guidari @tay1orjones |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks Benjamin 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Benjamin! great work 🔥
Just a small point - Could you please double-check if the focus state implemented here aligns with our last focus state discussion in the CAG call? As a recap from our conversation, we decided not to place focus on the first option in the open menu in Figma if nothing is selected. Thanks for verifying this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same over here as well, thanks.
Closes #3974
Images on style tab for Dropdown component has been updated - to be consistent with select all functionality.
Changelog
Changed
The following images have been changed, to include the "All" checkbox in the examples