docs: update progress indicator usage tab #3924
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hey @aubrey-oneal
|
|
Hey @guidari I put up a WIP PR which is why you're seeing missing content. I still need to work on the Placement imagery but I'd like to request a first review from our designers. One tricky thing was naming the progress states and I'm open to feedback on that. It's tricky because the states implied in the style tab have a mismatch with the icon names they use. I.e. 'Current' state uses the 'Incomplete' icon and 'Incomplete' state uses the 'Not started' icon. |
|
@aubrey-oneal Ohh okay! |
|
Thanks for the offer @guidari! I think for this PR our scope is going to be just getting docs up for the component as it is and we'll make some issues for potential future component updates! |
src/pages/components/progress-indicator/images/progress-indicator-usage-2.png
Outdated
Show resolved
Hide resolved
src/pages/components/progress-indicator/images/progress-indicator-usage-5.png
Outdated
Show resolved
Hide resolved
src/pages/components/progress-indicator/images/progress-indicator-usage-6.png
Outdated
Show resolved
Hide resolved
Co-authored-by: Lauren Rice <[email protected]>
Co-authored-by: Lauren Rice <[email protected]>
Co-authored-by: Lauren Rice <[email protected]>
Co-authored-by: Lauren Rice <[email protected]>
| alignment. | ||
|
|
||
| <Row> | ||
| <Column colLg={8}> |
There was a problem hiding this comment.
- You designed this image at 12 columns in your Figma file, so just checking if you still want it at 12 columns here instead of 8 columns!
Co-authored-by: Lauren Rice <[email protected]>
Co-authored-by: Lauren Rice <[email protected]>
|
Looks good Aubrey! I just think the anatomy image spanning 12 columns looks huge compared to the 8-column one. But yeah I understand the real size component is bigger than the 8–column image. I tried to scale it but not sure how that'll look live. But it's up to you. I also noticed that we have italic text for the first heading column and non -italic text in some cases. Maybe something to look at in the usage template update. But Lauren just issued the tag doc and she has italic text so I'd follow that for the states. 
|
|
|
||
| | State | Description | | ||
| | ----------- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | | ||
| | Completed | A step is complete when a user has filled out the required information within a step and progressed to the following step. When possible, use validation to confirm that a step has been completed before the user continues. All steps that have been completed are indicated by an outlined circle with a checkmark and a blue active line. | |
There was a problem hiding this comment.
Consider formatting the state names in italic text
aubrey-oneal
added
status: one more review 👀
and removed
status: ready for review 👀
labels
Closes #3464
This is issue is a complete rewrite of the progress indicator usage tab, which does not currently follow our template or provide sufficient information.
Changelog
New