Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update tag docs with interactive tags #3912

Merged

Conversation

laurenmrice
Copy link
Member

@laurenmrice laurenmrice commented Feb 13, 2024

Closes #3449 and #3818

This PR updates the Tag component Usage and Style documentation with our current content templates and additions of Interactive tags (Dismissible, Selectable, and Operational)


Changelog

New

  • New sections to match our content templates
  • New content and images for the Dismissible, Selectable, and Operational tags.

Removed

  • Old images

Copy link

vercel bot commented Feb 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 6, 2024 7:39pm

@laurenmrice
Copy link
Member Author

I need help with getting the newest changes of the A11y section addition, change of anchor links, and live demo section reorder to appear on my Tag Usage tab here.

@alisonjoseph
Copy link
Member

@laurenmrice fixed!

Copy link
Contributor

@Kritvi-bhatia17 Kritvi-bhatia17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @laurenmrice, I've added some comments. If you agree with them, you can commit the changes. If not, you can simply ignore them.

Also, I have a small question/suggestion: Do you think naming the images by adding numerical prefixes will be helpful?

src/pages/components/tag/style.mdx Outdated Show resolved Hide resolved
src/pages/components/tag/style.mdx Outdated Show resolved Hide resolved
src/pages/components/tag/style.mdx Outdated Show resolved Hide resolved
src/pages/components/tag/style.mdx Outdated Show resolved Hide resolved
src/pages/components/tag/style.mdx Outdated Show resolved Hide resolved
src/pages/components/tag/style.mdx Outdated Show resolved Hide resolved
src/pages/components/tag/style.mdx Outdated Show resolved Hide resolved
src/pages/components/tag/style.mdx Outdated Show resolved Hide resolved
src/pages/components/tag/style.mdx Outdated Show resolved Hide resolved
src/pages/components/tag/style.mdx Outdated Show resolved Hide resolved
Copy link
Member

@thyhmdo thyhmdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@laurenmrice laurenmrice merged commit bb66c86 into carbon-design-system:main Mar 6, 2024
7 checks passed
@laurenmrice laurenmrice deleted the interactive-tags-doc-update branch March 6, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants