Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update slider with range variant #3789

Merged
merged 30 commits into from
Nov 21, 2023
Merged

docs: update slider with range variant #3789

merged 30 commits into from
Nov 21, 2023

Conversation

laurenmrice
Copy link
Member

@laurenmrice laurenmrice commented Oct 30, 2023 •
edited
Loading

Closes
#3730
#3788

  • Updates the Slider component docs with the new range variant.
  • Updates the Slider component docs with Usage and Style template changes.

New

  • Added the range slider variant
  • Updated the documentation with the markdown content template for Usage/Style/Accessibility

Changed

  • Updated content
  • Updated images

Removed

  • Unused images
  • Unused videos

@vercel
Copy link

vercel bot commented Oct 30, 2023

@laurenmrice is attempting to deploy a commit to the Carbon Design System Team on Vercel.

A member of the Team first needs to authorize it.

@vercel Vercel
Copy link

vercel bot commented Oct 31, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2023 3:19pm

@laurenmrice laurenmrice marked this pull request as ready for review November 13, 2023 21:19
andreancardona
andreancardona approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made the changes to the live demo and looks good!

kingtraceyj
kingtraceyj approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@kingtraceyj kingtraceyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥 looks good to go!

@kodiakhq kodiakhq bot merged commit 5e82099 into carbon-design-system:main Nov 21, 2023
7 checks passed
@laurenmrice laurenmrice mentioned this pull request Mar 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kingtraceyj kingtraceyj kingtraceyj approved these changes

@andreancardona andreancardona andreancardona approved these changes

@tay1orjones tay1orjones Awaiting requested review from tay1orjones tay1orjones was automatically assigned from carbon-design-system/developers-system

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@laurenmrice @mbgower @kingtraceyj @andreancardona @alisonjoseph