Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Website] Menu and Menu buttons docs #3765

Merged
merged 38 commits into from
Nov 6, 2023
Merged

Conversation

thyhmdo
Copy link
Member

@thyhmdo thyhmdo commented Oct 6, 2023

These are new docs and new components added to v11

Closes:

Menu
#3494
#3568
Menu buttons
#3700
#3701

@vercel
Copy link

vercel bot commented Oct 6, 2023

@thyhmdo is attempting to deploy a commit to the Carbon Design System Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Oct 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2023 6:02pm

@thyhmdo thyhmdo marked this pull request as ready for review October 17, 2023 18:29
@thyhmdo thyhmdo requested a review from a team as a code owner October 17, 2023 18:29
Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me except for the Size image for Menu on the Style tab. I think something is not working right with the fixed image component for this one. @andreancardona Would you be able to troubleshoot this with Thy?

@kodiakhq kodiakhq bot merged commit 609aef2 into carbon-design-system:main Nov 6, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants