Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update tooltip content from a11y review #3655

Merged
merged 21 commits into from
Aug 28, 2023
Merged

docs: update tooltip content from a11y review #3655

merged 21 commits into from
Aug 28, 2023

Conversation

laurenmrice
Copy link
Member

@laurenmrice laurenmrice commented Jul 21, 2023 •
edited
Loading

Closes
#3412
#3624

This PR updates various places on the Usage and Style tab for the Tooltip component to address a11y review concerns.

Changed

Usage tab:

  • Changed Standard tooltip section to include more information about what kind of content can live within it.
  • Changed several images to not show an info icon.

Style tab:

  • Changed several images to not show an info icon.

Removed

  • Removed some old images that were no longer being used.

@vercel
Copy link

vercel bot commented Jul 21, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2023 5:23pm

@laurenmrice laurenmrice marked this pull request as ready for review August 22, 2023 19:11
@laurenmrice laurenmrice requested review from a team as code owners August 22, 2023 19:11
kingtraceyj
kingtraceyj approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@kingtraceyj kingtraceyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the updates look good! 💥

@kodiakhq kodiakhq bot merged commit 6326df5 into carbon-design-system:main Aug 28, 2023
6 checks passed
@laurenmrice laurenmrice deleted the tooltip-a11y-doc-update branch August 28, 2023 17:27
@laurenmrice laurenmrice mentioned this pull request Mar 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tay1orjones tay1orjones tay1orjones approved these changes

@kingtraceyj kingtraceyj kingtraceyj approved these changes

@andreancardona andreancardona Awaiting requested review from andreancardona andreancardona was automatically assigned from carbon-design-system/developers-system

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laurenmrice @tay1orjones @kingtraceyj