Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Adding dismissible docs #3581

Merged
merged 26 commits into from
Jul 5, 2023
Merged

docs: Adding dismissible docs #3581

merged 26 commits into from
Jul 5, 2023

Conversation

kingtraceyj
Copy link
Member

@kingtraceyj kingtraceyj commented Jun 6, 2023 •
edited by laurenmrice
Loading

Closes #3556

Changelog

New

  • adding dismissible tabs docs
  • updating style tab

@vercel
Copy link

vercel bot commented Jun 6, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 5, 2023 3:34pm

aubrey-oneal
aubrey-oneal requested changes Jun 9, 2023
View reviewed changes
src/pages/components/tabs/style.mdx Outdated Show resolved Hide resolved
src/pages/components/tabs/usage.mdx Outdated Show resolved Hide resolved
src/pages/components/tabs/style.mdx Outdated Show resolved Hide resolved
aagonzales
aagonzales reviewed Jun 9, 2023
View reviewed changes
Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The images with the divider lines on the style tab should be using this image component instead of the fixed one.

<Row>
<Column colLg={8}>

![Dismissible tabs](images/tabs-usage-15.png)

</Column>
</Row>

src/pages/components/tabs/usage.mdx Outdated Show resolved Hide resolved
src/pages/components/tabs/usage.mdx Outdated Show resolved Hide resolved
src/pages/components/tabs/usage.mdx Outdated Show resolved Hide resolved
@kingtraceyj kingtraceyj marked this pull request as ready for review June 14, 2023 15:38
@kingtraceyj kingtraceyj requested review from a team as code owners June 14, 2023 15:38
francinelucca
francinelucca reviewed Jun 14, 2023
View reviewed changes
Copy link
Collaborator

@francinelucca francinelucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, just have a comment regarding the "Triggering a new tab" section

src/pages/components/tabs/usage.mdx Show resolved Hide resolved
@thyhmdo thyhmdo marked this pull request as draft June 22, 2023 16:28
@thyhmdo thyhmdo marked this pull request as ready for review June 22, 2023 16:28
francinelucca
francinelucca approved these changes Jun 29, 2023
View reviewed changes
Copy link
Collaborator

@francinelucca francinelucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

aagonzales
aagonzales approved these changes Jun 30, 2023
View reviewed changes
Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too!

alisonjoseph
alisonjoseph approved these changes Jun 30, 2023
View reviewed changes
Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

aubrey-oneal
aubrey-oneal approved these changes Jun 30, 2023
View reviewed changes
Copy link
Member

@aubrey-oneal aubrey-oneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go! 🚀

@kingtraceyj kingtraceyj merged commit 34111aa into carbon-design-system:main Jul 5, 2023
6 checks passed
@kingtraceyj kingtraceyj deleted the dismissible-tabs-docs branch July 5, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tw15egan tw15egan tw15egan left review comments

@alisonjoseph alisonjoseph alisonjoseph approved these changes

@aagonzales aagonzales aagonzales approved these changes

@francinelucca francinelucca francinelucca approved these changes

@aubrey-oneal aubrey-oneal aubrey-oneal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs: update tabs with dismissable content
6 participants
@kingtraceyj @alisonjoseph @aagonzales @tw15egan @francinelucca @aubrey-oneal